From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [kvm-unit-tests PATCH] alloc: only warn once if we run out of log entries Date: Wed, 29 Jul 2015 15:52:51 +0200 Message-ID: <55B8DAB3.9070200@redhat.com> References: <1437739647-30313-1-git-send-email-drjones@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit To: Andrew Jones , kvm@vger.kernel.org Return-path: Received: from mx1.redhat.com ([209.132.183.28]:34885 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753396AbbG2Nwz (ORCPT ); Wed, 29 Jul 2015 09:52:55 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) by mx1.redhat.com (Postfix) with ESMTPS id 9043E36AA27 for ; Wed, 29 Jul 2015 13:52:55 +0000 (UTC) In-Reply-To: <1437739647-30313-1-git-send-email-drjones@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 24/07/2015 14:07, Andrew Jones wrote: > @@ -58,6 +59,7 @@ void phys_alloc_set_minimum_alignment(phys_addr_t align) > static phys_addr_t phys_alloc_aligned_safe(phys_addr_t size, > phys_addr_t align, bool safe) > { > + static bool not_warned = true; I wouldn't object to not having "not" in the name of this variable. :) Otherwise looks okay. Paolo > phys_addr_t addr, size_orig = size; > u64 top_safe = top; >