From: Paolo Bonzini <pbonzini@redhat.com>
To: "Andrew Jones" <drjones@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>
Cc: mttcg@greensocs.com, mark.burton@greensocs.com,
fred.konrad@greensocs.com, a.spyridakis@virtualopensystems.com,
kvm@vger.kernel.org
Subject: Re: [kvm-unit-tests RFC PATCH] arm/tlbflush.c: TLB flushing torture test [DEV]
Date: Wed, 29 Jul 2015 15:58:59 +0200 [thread overview]
Message-ID: <55B8DC23.5040007@redhat.com> (raw)
In-Reply-To: <20150727075411.GA3758@hawk.localdomain>
On 27/07/2015 09:54, Andrew Jones wrote:
> Also, please rename to tlbflush-test.c to differentiate it
> from an implementation of tlbflush support, and to make
> the standalone test name (if we commit those patches) more
> descriptive.
I disagree here. Support code would go in lib/arm.
> As we're adding tests faster now it's becoming clear that the '\' list
> isn't so great. To add a new test at the bottom we always have to modify
> the last line too. We should either add the new one at the top (right
> below the 'test-common =' line), or change this to a '+=' sequence like
> some other lists are done.
If you prefer += that's okay, but then please modify also cflatobjs in
Makefile and the x86 fragments in config/.
Paolo
next prev parent reply other threads:[~2015-07-29 13:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-24 13:25 [kvm-unit-tests RFC PATCH] arm/tlbflush.c: TLB flushing torture test [DEV] Alex Bennée
2015-07-27 7:54 ` Andrew Jones
2015-07-27 9:07 ` Alex Bennée
2015-07-27 10:32 ` Andrew Jones
2015-07-29 13:58 ` Paolo Bonzini [this message]
2015-07-29 14:36 ` Andrew Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B8DC23.5040007@redhat.com \
--to=pbonzini@redhat.com \
--cc=a.spyridakis@virtualopensystems.com \
--cc=alex.bennee@linaro.org \
--cc=drjones@redhat.com \
--cc=fred.konrad@greensocs.com \
--cc=kvm@vger.kernel.org \
--cc=mark.burton@greensocs.com \
--cc=mttcg@greensocs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.