From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:49652)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZKSLB-0008NO-Ln
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:28:18 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZKSL8-0006bY-DG
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:28:17 -0400
Received: from [59.151.112.132] (port=60129 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZKSL5-0006an-Nl
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:28:14 -0400
Message-ID: <55B8E2F5.9030403@cn.fujitsu.com>
Date: Wed, 29 Jul 2015 22:28:05 +0800
From: Yang Hongyang <yanghy@cn.fujitsu.com>
MIME-Version: 1.0
References: <1438167116-29270-1-git-send-email-yanghy@cn.fujitsu.com>
	<1438167116-29270-4-git-send-email-yanghy@cn.fujitsu.com>
	<396149374.399711.1438179348073.JavaMail.zimbra@redhat.com>
In-Reply-To: <396149374.399711.1438179348073.JavaMail.zimbra@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 03/12] netfilter: add netfilter_{add|del}
	commands
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: zhang zhanghailiang <zhang.zhanghailiang@huawei.com>, jasowang@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, stefanha@redhat.com



On 07/29/2015 10:15 PM, Thomas Huth wrote:
> On Wednesday, July 29, 2015 12:51:47 PM,
> "Yang Hongyang" <yanghy@cn.fujitsu.com> wrote:
>>
>> add netfilter_{add|del} commands
>> This is mostly the same with netdev_{add|del} commands.
>>
>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>> ---
> ...
>> diff --git a/hmp-commands.hx b/hmp-commands.hx
>> index d3b7932..5326a82 100644
>> --- a/hmp-commands.hx
>> +++ b/hmp-commands.hx
>> @@ -1253,6 +1253,36 @@ Remove host network device.
>>   ETEXI
>>
>>       {
>> +        .name       = "netfilter_add",
>> +        .args_type  = "netfilter:O",
>> +        .params     = "[type],id=str,netdev=str[,prop=value][,...]",
>
> I'm not fully sure about the syntax, but writing "[type]" in square
> brackets sounds like this parameter is optional to me. But if
> I've got this right, it is not optional, is it? So maybe use
> "<type>" instead?

Yes, <type> could be better here, it will be updated in the last
patch when we have added a type "buffer"!

>
>   Thomas
> .
>

-- 
Thanks,
Yang.