From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50964)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZKSPd-0003cU-2J
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:32:53 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZKSPV-0000IU-RS
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:32:53 -0400
Received: from [59.151.112.132] (port=16606 helo=heian.cn.fujitsu.com)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <yanghy@cn.fujitsu.com>) id 1ZKSPV-0000E2-4w
	for qemu-devel@nongnu.org; Wed, 29 Jul 2015 10:32:45 -0400
Message-ID: <55B8E3E8.90904@cn.fujitsu.com>
Date: Wed, 29 Jul 2015 22:32:08 +0800
From: Yang Hongyang <yanghy@cn.fujitsu.com>
MIME-Version: 1.0
References: <1438167116-29270-1-git-send-email-yanghy@cn.fujitsu.com>
	<1438167116-29270-2-git-send-email-yanghy@cn.fujitsu.com>
	<1291287430.378249.1438178034593.JavaMail.zimbra@redhat.com>
	<55B8DDB2.9080607@cn.fujitsu.com>
	<549013493.403650.1438179631766.JavaMail.zimbra@redhat.com>
In-Reply-To: <549013493.403650.1438179631766.JavaMail.zimbra@redhat.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH 01/12] net: add a new object netfilter
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Thomas Huth <thuth@redhat.com>
Cc: zhang zhanghailiang <zhang.zhanghailiang@huawei.com>, jasowang@redhat.com, qemu-devel@nongnu.org, mrhines@linux.vnet.ibm.com, stefanha@redhat.com



On 07/29/2015 10:20 PM, Thomas Huth wrote:
> On Wednesday, July 29, 2015 4:05:38 PM,
> "Yang Hongyang" <yanghy@cn.fujitsu.com> wrote:
>>
>> On 07/29/2015 09:53 PM, Thomas Huth wrote:
>>> On Wednesday, July 29, 2015 12:51:45 PM,
>>> "Yang Hongyang" <yanghy@cn.fujitsu.com> wrote:
>>>>
>>>> Signed-off-by: Yang Hongyang <yanghy@cn.fujitsu.com>
>>>
>>> Maybe add at least a very short patch description? You're doing
>>> a little bit more than just "add a new object netfilter" as
>>> mentioned in the title...
>>
>> How about:
>> Add a new object netfilter, used to capture packets send/receive
>> by network backend, init it after init net clients.
>
> I rather thought about a short remark about the fact that this
> patch also adds the "-netfilter" option. So maybe something
> like this:
>
> "Add the framework for a new netfilter object and a new
> -netfilter CLI option as a basis for the following patches"
>
> ?

Seems better, thank you, will update!

>
>   Thomas
> .
>

-- 
Thanks,
Yang.