All of lore.kernel.org
 help / color / mirror / Atom feed
From: Don Slutz <don.slutz@gmail.com>
To: "Michael S. Tsirkin" <mst@redhat.com>,
	Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
	"Don Slutz" <dslutz@verizon.com>,
	"Luiz Capitulino" <lcapitulino@redhat.com>,
	"Anthony Liguori" <aliguori@amazon.com>,
	"Andreas Färber" <afaerber@suse.de>,
	"Richard Henderson" <rth@twiddle.net>
Subject: Re: [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack
Date: Wed, 29 Jul 2015 11:25:12 -0400	[thread overview]
Message-ID: <55B8F058.6060408@Gmail.com> (raw)
In-Reply-To: <20150705083719-mutt-send-email-mst@redhat.com>

On 7/5/2015 2:40 AM, Michael S. Tsirkin wrote:
> On Fri, Jul 03, 2015 at 03:50:19PM +0200, Paolo Bonzini wrote:
>>
>> On 03/07/2015 15:08, Don Slutz wrote:
>>>> Creating it at the pc level and propagating makes code
>>>> messy but I'd go along with it if it made sense from
>>>> user's point of view, but it does not seem to make sense:
>>>> to me this looks more like a CPU feature than a machine property.
>>>> Or the property of the vmport rpc device that you created.
>>> Well this is not a clear area.  It does look more like a CPU feature.  I
>>> went with a machine feature because that is where "vmport" currently is.
>> I think it should be a vmport property.
>>
>> It would be cleaner to implement it using the MemTxAttrs mechanism, but
>> for KVM I'm afraid it would be too slow (and the slowness would affect
>> all I/O accesses, not just vmport ones, unless really ugly hacks are done).
>>
>> Paolo
> Can it ever be implemented for kvm? I couldn't think of a clean way to do it.
>

I do not know of a clean way.  For Xen I need to enable #GP fault 
reporting and add code to check in/out to the magic VMware port.  I 
would assume that some thing similar would be needed in kvm.  Hope this 
helps.

    -Don Slutz

  reply	other threads:[~2015-07-29 15:25 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-06-23 23:39 [Qemu-devel] [PATCH v8 0/8] Add limited support of VMware's hyper-call rpc Don Slutz
2015-06-23 23:39 ` [Qemu-devel] [PATCH v8 1/8] vmport: Switch to trace Don Slutz
2015-06-23 23:39 ` [Qemu-devel] [BUGFIX][PATCH v8 2/8] vmport: Fix vmport_cmd_ram_size Don Slutz
2015-06-23 23:39 ` [Qemu-devel] [PATCH v8 3/8] MAINTAINERS: add VMware port Don Slutz
2015-06-23 23:39 ` [Qemu-devel] [PATCH v8 4/8] vmport_rpc: Add the object vmport_rpc Don Slutz
2015-06-23 23:39 ` [Qemu-devel] [PATCH v8 5/8] vmport_rpc: Add limited support of VMware's hyper-call rpc Don Slutz
2015-06-23 23:39 ` [Qemu-devel] [PATCH v8 7/8] vmport_rpc: Add migration Don Slutz
2015-06-23 23:39 ` [Qemu-devel] [PATCH v8 8/8] vmport: Add VMware all ring hack Don Slutz
2015-07-01  6:50   ` Michael S. Tsirkin
2015-07-03 13:08     ` Don Slutz
2015-07-03 13:50       ` Paolo Bonzini
2015-07-05  6:40         ` Michael S. Tsirkin
2015-07-29 15:25           ` Don Slutz [this message]
2015-06-30 18:16 ` [Qemu-devel] [ping][PATCH v8 0/8] Add limited support of VMware's hyper-call rpc Don Slutz
     [not found] ` <1435102773-3498-7-git-send-email-Don.Slutz@Gmail.com>
2015-07-02 14:11   ` [Qemu-devel] [PATCH v8 6/8] vmport_rpc: Add QMP access to vmport_rpc object Markus Armbruster
2015-07-03 16:53     ` Don Slutz
2015-07-03 17:56       ` Markus Armbruster
2015-07-03 21:26         ` Don Slutz
2015-07-04  7:00           ` Markus Armbruster

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55B8F058.6060408@Gmail.com \
    --to=don.slutz@gmail.com \
    --cc=afaerber@suse.de \
    --cc=aliguori@amazon.com \
    --cc=armbru@redhat.com \
    --cc=dslutz@verizon.com \
    --cc=lcapitulino@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.