From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Goel, Akash" Subject: Re: [PATCH v6 04/19] drm/i915/gen8: Generalize PTE writing for GEN8 PPGTT Date: Thu, 30 Jul 2015 10:16:46 +0530 Message-ID: <55B9AC36.9010904@intel.com> References: <1438187043-34267-1-git-send-email-michel.thierry@intel.com> <1438187043-34267-5-git-send-email-michel.thierry@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by gabe.freedesktop.org (Postfix) with ESMTP id A2E726E432 for ; Wed, 29 Jul 2015 21:46:49 -0700 (PDT) In-Reply-To: <1438187043-34267-5-git-send-email-michel.thierry@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Michel Thierry , intel-gfx@lists.freedesktop.org, akash.goel@intel.com List-Id: intel-gfx@lists.freedesktop.org Ck9uIDcvMjkvMjAxNSA5OjUzIFBNLCBNaWNoZWwgVGhpZXJyeSB3cm90ZToKPiBUaGUgaW5zZXJ0 X2VudHJpZXMgZnVuY3Rpb24gd2FzIHRoZSBmdW5jdGlvbiB1c2VkIHRvIHdyaXRlIFBURXMuIEZv ciB0aGUKPiBQUEdUVCBpdCB3YXMgImhhcmRjb2RlZCIgdG8gb25seSB1bmRlcnN0YW5kIHR3byBs ZXZlbCBwYWdlIHRhYmxlcywgd2hpY2gKPiB3YXMgdGhlIGNhc2UgZm9yIEdFTjcuIFdlIGNhbiBy ZXVzZSB0aGlzIGZvciA0IGxldmVsIHBhZ2UgdGFibGVzLCBhbmQKPiByZW1vdmUgdGhlIGNvbmNl cHQgb2YgaW5zZXJ0X2VudHJpZXMsIHdoaWNoIHdhcyBuZXZlciB2aWFibGUgcGFzdCAyCj4gbGV2 ZWwgcGFnZSB0YWJsZXMgYW55d2F5LCBidXQgaXQgcmVxdWlyZXMgYSBiaXQgb2YgcmV3b3JrIHRv IG1ha2UgdGhlCj4gZnVuY3Rpb24gYSBiaXQgbW9yZSBnZW5lcmljLgo+Cj4gVGhpcyBwYXRjaCBi ZWdpbnMgdGhlIGdlbmVyYWxpemF0aW9uIHdvcmssIGFuZCBpdCB3aWxsIGJlIGhlYXZpbHkgdXNl ZAo+IHVwb24gd2hlbiB0aGUgNDhiIGNvZGUgaXMgY29tcGxldGUuIFRoZSBwYXRjaCBzZXJpZXMg YXR0ZW1wdHMgdG8gbWFrZQo+IGVhY2ggZnVuY3Rpb24gd2hpY2ggdG91Y2hlcyBhIHBhcnQgb2Yg Y29kZSBzcGVjaWZpYyB0byB0aGUgcGFnZSB0YWJsZQo+IGxldmVsIGFuZCBoZXJlIGlzIG5vIGV4 Y2VwdGlvbi4KPgo+IHYyOiBSZWJhc2UgYWZ0ZXIgTWlrYSdzIHBwZ3R0IGNsZWFudXAgLyBzY3Jh dGNoIG1lcmdlIHBhdGNoIHNlcmllcy4KPiB2MzogUmViYXNlIGFmdGVyIGZpbmFsIG1lcmdlZCB2 ZXJzaW9uIG9mIE1pa2EncyBwcGd0dC9zY3JhdGNoIHBhdGNoZXMuCj4KPiBTaWduZWQtb2ZmLWJ5 OiBCZW4gV2lkYXdza3kgPGJlbkBid2lkYXdzay5uZXQ+Cj4gU2lnbmVkLW9mZi1ieTogTWljaGVs IFRoaWVycnkgPG1pY2hlbC50aGllcnJ5QGludGVsLmNvbT4gKHYyKQo+IC0tLQo+ICAgZHJpdmVy cy9ncHUvZHJtL2k5MTUvaTkxNV9nZW1fZ3R0LmMgfCA1MiArKysrKysrKysrKysrKysrKysrKysr KysrKystLS0tLS0tLS0tCj4gICAxIGZpbGUgY2hhbmdlZCwgMzkgaW5zZXJ0aW9ucygrKSwgMTMg ZGVsZXRpb25zKC0pCj4KPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fZ3R0LmMgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IGluZGV4IGJk NTY5NzkuLmYzMzhhMTMgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9n ZW1fZ3R0LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2dlbV9ndHQuYwo+IEBA IC02MDAsMjQgKzYwMCwyMSBAQCBzdGF0aWMgaW50IGdlbjhfbW1fc3dpdGNoKHN0cnVjdCBpOTE1 X2h3X3BwZ3R0ICpwcGd0dCwKPiAgIAlyZXR1cm4gMDsKPiAgIH0KPgo+IC1zdGF0aWMgdm9pZCBn ZW44X3BwZ3R0X2NsZWFyX3JhbmdlKHN0cnVjdCBpOTE1X2FkZHJlc3Nfc3BhY2UgKnZtLAo+IC0J CQkJICAgdWludDY0X3Qgc3RhcnQsCj4gLQkJCQkgICB1aW50NjRfdCBsZW5ndGgsCj4gLQkJCQkg ICBib29sIHVzZV9zY3JhdGNoKQo+ICtzdGF0aWMgdm9pZCBnZW44X3BwZ3R0X2NsZWFyX3B0ZV9y YW5nZShzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwKPiArCQkJCSAgICAgICBzdHJ1Y3Qg aTkxNV9wYWdlX2RpcmVjdG9yeV9wb2ludGVyICpwZHAsCj4gKwkJCQkgICAgICAgdWludDY0X3Qg c3RhcnQsCj4gKwkJCQkgICAgICAgdWludDY0X3QgbGVuZ3RoLAo+ICsJCQkJICAgICAgIGdlbjhf cHRlX3Qgc2NyYXRjaF9wdGUpCj4gICB7Cj4gICAJc3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0 ID0KPiAgIAkJY29udGFpbmVyX29mKHZtLCBzdHJ1Y3QgaTkxNV9od19wcGd0dCwgYmFzZSk7Cj4g LQlzdHJ1Y3QgaTkxNV9wYWdlX2RpcmVjdG9yeV9wb2ludGVyICpwZHAgPSAmcHBndHQtPnBkcDsg LyogRklYTUU6IDQ4YiAqLwo+IC0JZ2VuOF9wdGVfdCAqcHRfdmFkZHIsIHNjcmF0Y2hfcHRlOwo+ ICsJZ2VuOF9wdGVfdCAqcHRfdmFkZHI7Cj4gICAJdW5zaWduZWQgcGRwZSA9IHN0YXJ0ID4+IEdF TjhfUERQRV9TSElGVCAmIEdFTjhfUERQRV9NQVNLOwo+ICAgCXVuc2lnbmVkIHBkZSA9IHN0YXJ0 ID4+IEdFTjhfUERFX1NISUZUICYgR0VOOF9QREVfTUFTSzsKPiAgIAl1bnNpZ25lZCBwdGUgPSBz dGFydCA+PiBHRU44X1BURV9TSElGVCAmIEdFTjhfUFRFX01BU0s7Cj4gICAJdW5zaWduZWQgbnVt X2VudHJpZXMgPSBsZW5ndGggPj4gUEFHRV9TSElGVDsKPiAgIAl1bnNpZ25lZCBsYXN0X3B0ZSwg aTsKPgo+IC0Jc2NyYXRjaF9wdGUgPSBnZW44X3B0ZV9lbmNvZGUocHhfZG1hKHBwZ3R0LT5iYXNl LnNjcmF0Y2hfcGFnZSksCj4gLQkJCQkgICAgICBJOTE1X0NBQ0hFX0xMQywgdXNlX3NjcmF0Y2gp Owo+IC0KClNvcnJ5IGZvciB0aGUgbGF0ZSBjb21tZW50LgpXb3VsZCBpdCBiZSBiZXR0ZXIgdG8g aGF2ZSBhIFdBUk5fT04gY2hlY2sgaGVyZSBvbiBOVUxMIHZhbHVlIG9mIHBkcCAKcG9pbnRlciwg Y29uc2lkZXJpbmcgdGhlIHBkcCB3aWxsIG5vIGxvbmdlciBiZSBzdGF0aWMgaW4gY2FzZSBvZiA0 OCBiaXQuCgpBY3R1YWxseSB0aGVyZSBhcmUgYWxyZWFkeSBzdWNoIGNoZWNrcyB1c2VkIGluIHRo aXMgZnVuY3Rpb24gZm9yIHBkLCBwdCAKYW5kIHBhZ2UgcG9pbnRlcnMuCgpCZXN0IHJlZ2FyZHMK QWthc2gKCj4gICAJd2hpbGUgKG51bV9lbnRyaWVzKSB7Cj4gICAJCXN0cnVjdCBpOTE1X3BhZ2Vf ZGlyZWN0b3J5ICpwZDsKPiAgIAkJc3RydWN0IGk5MTVfcGFnZV90YWJsZSAqcHQ7Cj4gQEAgLTY1 NiwxNCArNjUzLDMwIEBAIHN0YXRpYyB2b2lkIGdlbjhfcHBndHRfY2xlYXJfcmFuZ2Uoc3RydWN0 IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gICAJfQo+ICAgfQo+Cj4gLXN0YXRpYyB2b2lkIGdl bjhfcHBndHRfaW5zZXJ0X2VudHJpZXMoc3RydWN0IGk5MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4g LQkJCQkgICAgICBzdHJ1Y3Qgc2dfdGFibGUgKnBhZ2VzLAo+IC0JCQkJICAgICAgdWludDY0X3Qg c3RhcnQsCj4gLQkJCQkgICAgICBlbnVtIGk5MTVfY2FjaGVfbGV2ZWwgY2FjaGVfbGV2ZWwsIHUz MiB1bnVzZWQpCj4gK3N0YXRpYyB2b2lkIGdlbjhfcHBndHRfY2xlYXJfcmFuZ2Uoc3RydWN0IGk5 MTVfYWRkcmVzc19zcGFjZSAqdm0sCj4gKwkJCQkgICB1aW50NjRfdCBzdGFydCwKPiArCQkJCSAg IHVpbnQ2NF90IGxlbmd0aCwKPiArCQkJCSAgIGJvb2wgdXNlX3NjcmF0Y2gpCj4gICB7Cj4gICAJ c3RydWN0IGk5MTVfaHdfcHBndHQgKnBwZ3R0ID0KPiAgIAkJY29udGFpbmVyX29mKHZtLCBzdHJ1 Y3QgaTkxNV9od19wcGd0dCwgYmFzZSk7Cj4gICAJc3RydWN0IGk5MTVfcGFnZV9kaXJlY3Rvcnlf cG9pbnRlciAqcGRwID0gJnBwZ3R0LT5wZHA7IC8qIEZJWE1FOiA0OGIgKi8KPiArCj4gKwlnZW44 X3B0ZV90IHNjcmF0Y2hfcHRlID0gZ2VuOF9wdGVfZW5jb2RlKHB4X2RtYSh2bS0+c2NyYXRjaF9w YWdlKSwKPiArCQkJCQkJIEk5MTVfQ0FDSEVfTExDLCB1c2Vfc2NyYXRjaCk7Cj4gKwo+ICsJZ2Vu OF9wcGd0dF9jbGVhcl9wdGVfcmFuZ2Uodm0sIHBkcCwgc3RhcnQsIGxlbmd0aCwgc2NyYXRjaF9w dGUpOwo+ICt9Cj4gKwo+ICtzdGF0aWMgdm9pZAo+ICtnZW44X3BwZ3R0X2luc2VydF9wdGVfZW50 cmllcyhzdHJ1Y3QgaTkxNV9hZGRyZXNzX3NwYWNlICp2bSwKPiArCQkJICAgICAgc3RydWN0IGk5 MTVfcGFnZV9kaXJlY3RvcnlfcG9pbnRlciAqcGRwLAo+ICsJCQkgICAgICBzdHJ1Y3Qgc2dfdGFi bGUgKnBhZ2VzLAo+ICsJCQkgICAgICB1aW50NjRfdCBzdGFydCwKPiArCQkJICAgICAgZW51bSBp OTE1X2NhY2hlX2xldmVsIGNhY2hlX2xldmVsKQo+ICt7Cj4gKwlzdHJ1Y3QgaTkxNV9od19wcGd0 dCAqcHBndHQgPQo+ICsJCWNvbnRhaW5lcl9vZih2bSwgc3RydWN0IGk5MTVfaHdfcHBndHQsIGJh c2UpOwo+ICAgCWdlbjhfcHRlX3QgKnB0X3ZhZGRyOwo+ICAgCXVuc2lnbmVkIHBkcGUgPSBzdGFy dCA+PiBHRU44X1BEUEVfU0hJRlQgJiBHRU44X1BEUEVfTUFTSzsKPiAgIAl1bnNpZ25lZCBwZGUg PSBzdGFydCA+PiBHRU44X1BERV9TSElGVCAmIEdFTjhfUERFX01BU0s7Cj4gQEAgLTcwMCw2ICs3 MTMsMTkgQEAgc3RhdGljIHZvaWQgZ2VuOF9wcGd0dF9pbnNlcnRfZW50cmllcyhzdHJ1Y3QgaTkx NV9hZGRyZXNzX3NwYWNlICp2bSwKPiAgIAkJa3VubWFwX3B4KHBwZ3R0LCBwdF92YWRkcik7Cj4g ICB9Cj4KPiArc3RhdGljIHZvaWQgZ2VuOF9wcGd0dF9pbnNlcnRfZW50cmllcyhzdHJ1Y3QgaTkx NV9hZGRyZXNzX3NwYWNlICp2bSwKPiArCQkJCSAgICAgIHN0cnVjdCBzZ190YWJsZSAqcGFnZXMs Cj4gKwkJCQkgICAgICB1aW50NjRfdCBzdGFydCwKPiArCQkJCSAgICAgIGVudW0gaTkxNV9jYWNo ZV9sZXZlbCBjYWNoZV9sZXZlbCwKPiArCQkJCSAgICAgIHUzMiB1bnVzZWQpCj4gK3sKPiArCXN0 cnVjdCBpOTE1X2h3X3BwZ3R0ICpwcGd0dCA9Cj4gKwkJY29udGFpbmVyX29mKHZtLCBzdHJ1Y3Qg aTkxNV9od19wcGd0dCwgYmFzZSk7Cj4gKwlzdHJ1Y3QgaTkxNV9wYWdlX2RpcmVjdG9yeV9wb2lu dGVyICpwZHAgPSAmcHBndHQtPnBkcDsgLyogRklYTUU6IDQ4YiAqLwo+ICsKPiArCWdlbjhfcHBn dHRfaW5zZXJ0X3B0ZV9lbnRyaWVzKHZtLCBwZHAsIHBhZ2VzLCBzdGFydCwgY2FjaGVfbGV2ZWwp Owo+ICt9Cj4gKwo+ICAgc3RhdGljIHZvaWQgZ2VuOF9mcmVlX3BhZ2VfdGFibGVzKHN0cnVjdCBk cm1fZGV2aWNlICpkZXYsCj4gICAJCQkJICBzdHJ1Y3QgaTkxNV9wYWdlX2RpcmVjdG9yeSAqcGQp Cj4gICB7Cj4KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K SW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0 dHA6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK