From: Paolo Bonzini <pbonzini@redhat.com>
To: Steve Rutherford <srutherford@google.com>
Cc: kvm@vger.kernel.org
Subject: Re: [PATCH kvm-unit-tests] x86: ioapic: add tests around retriggering of level interrupts
Date: Thu, 30 Jul 2015 09:13:51 +0200 [thread overview]
Message-ID: <55B9CEAF.5040100@redhat.com> (raw)
In-Reply-To: <20150730031448.GB15229@google.com>
On 30/07/2015 05:14, Steve Rutherford wrote:
>> > +static void test_ioapic_level_retrigger(void)
>> > +{
>> > + handle_irq(0x9a, ioapic_isr_9a);
>> > + set_ioapic_redir(0x0e, 0x9a, LEVEL_TRIGGERED);
>> > +
>> > + asm volatile ("cli");
>> > + set_irq_line(0x0e, 1);
>> > + while (g_isr_9a != 2)
>> > + asm volatile ("sti; hlt; cli");
> This seems sketchy. The test should be able to exit this and fail.
You're right, this shouldn't take more than 10-15 iterations of the
while loop.
Paolo
prev parent reply other threads:[~2015-07-30 7:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-29 13:28 [PATCH kvm-unit-tests] x86: ioapic: add tests around retriggering of level interrupts Paolo Bonzini
2015-07-30 3:14 ` Steve Rutherford
2015-07-30 7:13 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55B9CEAF.5040100@redhat.com \
--to=pbonzini@redhat.com \
--cc=kvm@vger.kernel.org \
--cc=srutherford@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.