From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH 2/2] KVM: x86: store IOAPIC-handled vectors in each VCPU Date: Thu, 30 Jul 2015 09:19:51 +0200 Message-ID: <55B9D017.2090107@redhat.com> References: <1438177055-26764-1-git-send-email-pbonzini@redhat.com> <1438177055-26764-3-git-send-email-pbonzini@redhat.com> <20150730035543.GE15229@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, alex.williamson@redhat.com, yang.z.zhang@intel.com, srutherford@intel.com To: Steve Rutherford Return-path: In-Reply-To: <20150730035543.GE15229@google.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On 30/07/2015 05:55, Steve Rutherford wrote: > > static void vcpu_scan_ioapic(struct kvm_vcpu *vcpu) > > { > > - u64 eoi_exit_bitmap[4]; > > - > > if (!kvm_apic_hw_enabled(vcpu->arch.apic)) > > return; > > > > - memset(eoi_exit_bitmap, 0, 32); > > + memset(vcpu->arch.eoi_exit_bitmap, 0, 256 / 8); > > > > - kvm_ioapic_scan_entry(vcpu, eoi_exit_bitmap); > > - kvm_x86_ops->load_eoi_exitmap(vcpu, eoi_exit_bitmap); > > + kvm_ioapic_scan_entry(vcpu, vcpu->arch.eoi_exit_bitmap); > Nit: Does scan entry still need to carry around the pointer to the bitmap? IIRC I was copying what you did in your patch, but I also think it's better this way. The IOAPIC has no business in the vcpu structure's fields; it only needs it in order to pass vcpu to kvm_apic_match_dest. Paolo