From mboxrd@z Thu Jan  1 00:00:00 1970
From: Olivier MATZ <olivier.matz@6wind.com>
Subject: Re: [PATCH v10 0/3] deduplicate EAL common functions
Date: Thu, 30 Jul 2015 10:12:31 +0200
Message-ID: <55B9DC6F.7040506@6wind.com>
References: <1437852868-6031-1-git-send-email-rkerur@gmail.com>
 <1437958594-29468-1-git-send-email-thomas.monjalon@6wind.com>
 <3055506.vZLM2IGfDr@xps13>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>, rkerur@gmail.com
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wi0-f179.google.com (mail-wi0-f179.google.com
 [209.85.212.179]) by dpdk.org (Postfix) with ESMTP id 29CC1C4DE
 for <dev@dpdk.org>; Thu, 30 Jul 2015 10:12:40 +0200 (CEST)
Received: by wibud3 with SMTP id ud3so10703293wib.1
 for <dev@dpdk.org>; Thu, 30 Jul 2015 01:12:40 -0700 (PDT)
In-Reply-To: <3055506.vZLM2IGfDr@xps13>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi Thomas & Ravi,

On 07/27/2015 02:59 AM, Thomas Monjalon wrote:
> 2015-07-27 02:56, Thomas Monjalon:
>> v9 was a subset of previous deduplications by Ravi Kerur.
>> This v10 address the comments I've done on v9.
>>
>> Ravi Kerur (3):
>>    eal: deduplicate lcore initialization
>>    eal: deduplicate timer functions
>>    eal: deduplicate memory initialization
>
> Applied shortly to integrate this old pending cleanup in RC2.
>

When I try to compile the dpdk for x86_x32-native-linuxapp-gcc , I
get the following compilation error:

   CC eal_common_timer.o
In file included from /usr/include/sys/sysctl.h:63:0,
                  from 
/home/matz/dpdk-pkg-cron/dpdk.org/lib/librte_eal/common/eal_common_timer.c:39:
/usr/include/bits/sysctl.h:19:3: error: #error "sysctl system call is 
unsupported in x32 kernel"
  # error "sysctl system call is unsupported in x32 kernel"
    ^

Removing the "#include <sys/sysctl.h>" line fixes the issue without
impacting the compilation. I think this include is not needed and
could be removed.
I can provide a patch if it's ok for you.

Regards,
Olivier