Re: [PATCH v7 4/4] KVM: x86: Add support for local interrupt requests from userspace

[Paolo Bonzini <pbonzini@redhat.com>]

On 30/07/2015 08:21, Steve Rutherford wrote:
>  Architectures: x86, ppc, mips
>  Type: vcpu ioctl
>  Parameters: struct kvm_interrupt (in)
> -Returns: 0 on success, -1 on error
> +Returns: 0 on success, negative on failure.

Really returns -1 because...

>  
> -Queues a hardware interrupt vector to be injected.  This is only
> -useful if in-kernel local APIC or equivalent is not used.
> +Queues a hardware interrupt vector to be injected.
>  
>  /* for KVM_INTERRUPT */
>  struct kvm_interrupt {
> @@ -414,7 +413,14 @@ struct kvm_interrupt {
>  
>  X86:
>  
> -Note 'irq' is an interrupt vector, not an interrupt pin or line.
> +Returns: 0 on success,
> +	 -EEXIST if an interrupt is already enqueued
> +	 -EINVAL the the irq number is invalid
> +	 -ENXIO if the PIC is in the kernel
> +	 -EFAULT if the pointer is invalid

... these are errno values.  No need to resend.

Paolo

> +Note 'irq' is an interrupt vector, not an interrupt pin or line. This
> +ioctl is useful if the in-kernel PIC is not used.