From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH v7 1/4] KVM: x86: Split the APIC from the rest of IRQCHIP. Date: Thu, 30 Jul 2015 11:38:20 +0200 Message-ID: <55B9F08C.6080604@redhat.com> References: <1438237303-19124-1-git-send-email-srutherford@google.com> <55B9DEA2.1070304@redhat.com> <20150730083739.GB19524@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Cc: kvm@vger.kernel.org To: Steve Rutherford Return-path: Received: from mail-wi0-f174.google.com ([209.85.212.174]:36818 "EHLO mail-wi0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750890AbbG3JiW (ORCPT ); Thu, 30 Jul 2015 05:38:22 -0400 Received: by wicgb10 with SMTP id gb10so235556257wic.1 for ; Thu, 30 Jul 2015 02:38:21 -0700 (PDT) In-Reply-To: <20150730083739.GB19524@google.com> Sender: kvm-owner@vger.kernel.org List-ID: On 30/07/2015 10:37, Steve Rutherford wrote: > This looks a bit non-sensical, but is overprepared for the introduction > IOAPIC hotplug, which two patches down the line. Changing it is fine, > you'll just need to merge the very same change back. By "IOAPIC hotplug" you mean changing the number of reserved routes? Is it necessary? You could just reserve a bunch of routes depending on the maximum number of IOAPICs. And especially, is it documented? :) The docs say "Fails [...] if the irqchip is already in the kernel (i.e. KVM_CREATE_IRQCHIP has already been called)". As before, no need to resend patches for now. Let's finish discussing all pending points, then I'll push what I have to kvm.git and you can test it with your VMM. There should be time between this week and the next. Paolo