From mboxrd@z Thu Jan 1 00:00:00 1970 From: nicolas.ferre@atmel.com (Nicolas Ferre) Date: Thu, 30 Jul 2015 14:03:54 +0200 Subject: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board In-Reply-To: <20150618154537.GM27492@piout.net> References: <1434449315-9243-1-git-send-email-josh.wu@atmel.com> <20150618154537.GM27492@piout.net> Message-ID: <55BA12AA.3030102@atmel.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Le 18/06/2015 17:45, Alexandre Belloni a ?crit : > Hi, > > Seems good to me, a small comment below: > > On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote : >> @@ -1068,8 +1076,12 @@ >> clocks = <&isi_clk>; >> clock-names = "isi_clk"; >> pinctrl-names = "default"; >> - pinctrl-0 = <&pinctrl_isi>; >> + pinctrl-0 = <&pinctrl_isi_data_0_7>; > > I would say that the pinctrl is board specific so both pinctrl-names and > pinctrl-0 should go to at91sam9m10g45ek.dts I move it in the board file. Otherwise: Acked-by: Nicolas Ferre and stacked on top of at91-4.3-dt. Bye, -- Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Ferre Subject: Re: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board Date: Thu, 30 Jul 2015 14:03:54 +0200 Message-ID: <55BA12AA.3030102@atmel.com> References: <1434449315-9243-1-git-send-email-josh.wu@atmel.com> <20150618154537.GM27492@piout.net> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150618154537.GM27492@piout.net> Sender: linux-kernel-owner@vger.kernel.org To: Alexandre Belloni , Josh Wu Cc: linux-arm-kernel@lists.infradead.org, Mark Rutland , devicetree@vger.kernel.org, Russell King , Pawel Moll , Ian Campbell , linux-kernel@vger.kernel.org, Rob Herring , Kumar Gala , Jean-Christophe Plagniol-Villard , Andrew Victor List-Id: devicetree@vger.kernel.org Le 18/06/2015 17:45, Alexandre Belloni a =E9crit : > Hi, >=20 > Seems good to me, a small comment below: >=20 > On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote : >> @@ -1068,8 +1076,12 @@ >> clocks =3D <&isi_clk>; >> clock-names =3D "isi_clk"; >> pinctrl-names =3D "default"; >> - pinctrl-0 =3D <&pinctrl_isi>; >> + pinctrl-0 =3D <&pinctrl_isi_data_0_7>; >=20 > I would say that the pinctrl is board specific so both pinctrl-names = and > pinctrl-0 should go to at91sam9m10g45ek.dts I move it in the board file. Otherwise: Acked-by: Nicolas Ferre and stacked on top of at91-4.3-dt. Bye, --=20 Nicolas Ferre From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751489AbbG3MFE (ORCPT ); Thu, 30 Jul 2015 08:05:04 -0400 Received: from eusmtp01.atmel.com ([212.144.249.242]:17476 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750734AbbG3MFC (ORCPT ); Thu, 30 Jul 2015 08:05:02 -0400 Message-ID: <55BA12AA.3030102@atmel.com> Date: Thu, 30 Jul 2015 14:03:54 +0200 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Alexandre Belloni , Josh Wu CC: , Mark Rutland , , Russell King , Pawel Moll , Ian Campbell , , Rob Herring , Kumar Gala , "Jean-Christophe Plagniol-Villard" , Andrew Victor Subject: Re: [PATCH v2 1/2] ARM: at91: dts: add isi & ov2640 dt nodes for at91sam9m10g45ek board References: <1434449315-9243-1-git-send-email-josh.wu@atmel.com> <20150618154537.GM27492@piout.net> In-Reply-To: <20150618154537.GM27492@piout.net> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 18/06/2015 17:45, Alexandre Belloni a écrit : > Hi, > > Seems good to me, a small comment below: > > On 16/06/2015 at 18:08:34 +0800, Josh Wu wrote : >> @@ -1068,8 +1076,12 @@ >> clocks = <&isi_clk>; >> clock-names = "isi_clk"; >> pinctrl-names = "default"; >> - pinctrl-0 = <&pinctrl_isi>; >> + pinctrl-0 = <&pinctrl_isi_data_0_7>; > > I would say that the pinctrl is board specific so both pinctrl-names and > pinctrl-0 should go to at91sam9m10g45ek.dts I move it in the board file. Otherwise: Acked-by: Nicolas Ferre and stacked on top of at91-4.3-dt. Bye, -- Nicolas Ferre