From: Sagi Grimberg <sagig-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
To: Or Gerlitz <gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
Cc: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>,
"linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 05/22] IB/iser: Get rid of un-maintained counters
Date: Thu, 30 Jul 2015 15:05:59 +0300 [thread overview]
Message-ID: <55BA1327.20701@dev.mellanox.co.il> (raw)
In-Reply-To: <CAJ3xEMj6Pupc0+ZqKEaB86kTcJq3P=Z1EoiH-EHzWuaznw48bQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On 7/30/2015 1:20 PM, Or Gerlitz wrote:
> On Thu, Jul 30, 2015 at 11:06 AM, Sagi Grimberg <sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> wrote:
>> We don't update those anywhere in the code and they
>> seem pretty useless (no one seem to care about those).
>>
>> qp_tx_queue_full: We never should get this
>
> why?
We reserve slots in our queue-pair based on the maximum inflight IOs.
And we lower the user's cmds_max to our queue-pair size.
So we never get there - also the code never touches this counter.
>
>> fmr_map_not_avail: We can never get to this
>
> why? if for some reason fmr pool thread which does unmapping on the
> background is slowed/delayed? or the
> device firmware/hardware is in troubles?
For FMRs we allocate x2 FMRs to absorb the background unmapping.
Besides, We don't increment this in any place in the code...
I don't see a point in keeping parameters that are not maintained.
Actually I never noticed they were there... a quick git searched didn't
show any usage of those ever.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-07-30 12:05 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 8:06 [PATCH 00/22] iser patches for 4.3 Sagi Grimberg
[not found] ` <1438243595-32288-1-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-30 8:06 ` [PATCH 01/22] IB/iser: Change some module parameters to be RO Sagi Grimberg
2015-07-30 8:06 ` [PATCH 02/22] IB/iser: Change minor assignments and logging prints Sagi Grimberg
2015-07-30 8:06 ` [PATCH 03/22] IB/iser: Remove '.' from log message Sagi Grimberg
2015-07-30 8:06 ` [PATCH 04/22] IB/iser: Fix missing return status check in iser_send_data_out Sagi Grimberg
2015-07-30 8:06 ` [PATCH 05/22] IB/iser: Get rid of un-maintained counters Sagi Grimberg
[not found] ` <1438243595-32288-6-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-30 10:20 ` Or Gerlitz
[not found] ` <CAJ3xEMj6Pupc0+ZqKEaB86kTcJq3P=Z1EoiH-EHzWuaznw48bQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-30 12:05 ` Sagi Grimberg [this message]
2015-07-30 8:06 ` [PATCH 06/22] IB/iser: Fix possible bogus DMA unmapping Sagi Grimberg
[not found] ` <1438243595-32288-7-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-30 10:23 ` Or Gerlitz
[not found] ` <CAJ3xEMiqQ6GNnJJ8wEJPVyenRxP=bb6ewm5aSWHHL-4X=oq1eg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-30 12:09 ` Sagi Grimberg
[not found] ` <55BA13F4.9090805-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-07-30 13:07 ` COMMERCIAL: " Or Gerlitz
2015-07-30 8:06 ` [PATCH 07/22] IB/iser: Remove a redundant always-false condition Sagi Grimberg
2015-07-30 8:06 ` [PATCH 08/22] IB/iser: Remove an unneeded print for unaligned memory Sagi Grimberg
2015-07-30 8:06 ` [PATCH 09/22] IB/iser: Introduce struct iser_reg_resources Sagi Grimberg
2015-07-30 8:06 ` [PATCH 10/22] IB/iser: Rename struct fast_reg_descriptor -> iser_fr_desc Sagi Grimberg
2015-07-30 8:06 ` [PATCH 11/22] IB/iser: Remove dead code in fmr_pool alloc/free Sagi Grimberg
[not found] ` <1438243595-32288-12-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-30 10:31 ` Or Gerlitz
[not found] ` <CAJ3xEMh7H4+hUfV8qUr5wTsV02YG0vXTPGWLR=KKHeBMxA-zYA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-30 12:23 ` Sagi Grimberg
[not found] ` <55BA1736.2010204-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-07-30 13:52 ` Or Gerlitz
2015-07-30 8:06 ` [PATCH 12/22] IB/iser: Introduce iser_reg_ops Sagi Grimberg
[not found] ` <1438243595-32288-13-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-30 15:05 ` Steve Wise
[not found] ` <55BA3D51.8050003-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2015-07-30 17:25 ` Jason Gunthorpe
[not found] ` <20150730172526.GC25282-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-08-02 7:59 ` Sagi Grimberg
2015-07-30 17:32 ` Jason Gunthorpe
2015-07-30 8:06 ` [PATCH 13/22] IB/iser: Move fastreg descriptor allocation to iser_create_fastreg_desc Sagi Grimberg
2015-07-30 8:06 ` [PATCH 14/22] IB/iser: Introduce iser registration pool struct Sagi Grimberg
2015-07-30 8:06 ` [PATCH 15/22] IB/iser: Maintain connection fmr_pool under a single registration descriptor Sagi Grimberg
2015-07-30 8:06 ` [PATCH 16/22] IB/iser: Rename iser_reg_page_vec to iser_fast_reg_fmr Sagi Grimberg
2015-07-30 8:06 ` [PATCH 17/22] IB/iser: Make reg_desc_get a per device routine Sagi Grimberg
2015-07-30 8:06 ` [PATCH 18/22] IB/iser: Unify fast memory registration flows Sagi Grimberg
2015-07-30 8:06 ` [PATCH 19/22] IB/iser: Pass registration pool a size parameter Sagi Grimberg
2015-07-30 8:06 ` [PATCH 20/22] IB/iser: Support up to 8MB data transfer in a single command Sagi Grimberg
[not found] ` <1438243595-32288-21-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-30 10:22 ` Or Gerlitz
[not found] ` <CAJ3xEMjjzrezJ6UEH3rGD5Qu7DPLQM4Lw-JnOFrEvhLGd90spA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-30 12:23 ` Sagi Grimberg
2015-07-30 15:12 ` Steve Wise
[not found] ` <55BA3EF6.6080800-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org>
2015-08-02 8:01 ` Sagi Grimberg
[not found] ` <55BDCE4D.5080601-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-08-03 13:57 ` Atchley, Scott
[not found] ` <25F51949-82B5-4BA8-8472-6056BC43C747-1Heg1YXhbW8@public.gmane.org>
2015-08-04 17:10 ` Sagi Grimberg
[not found] ` <55C0F1FF.7010207-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
2015-08-04 21:21 ` Or Gerlitz
2015-07-30 8:06 ` [PATCH 21/22] IB/iser: Add debug prints to the various memory registration methods Sagi Grimberg
2015-07-30 8:06 ` [PATCH 22/22] IB/iser: Chain all iser transaction send work requests Sagi Grimberg
[not found] ` <1438243595-32288-23-git-send-email-sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2015-07-30 10:27 ` Or Gerlitz
[not found] ` <CAJ3xEMhtEuf4y0=1XyC7qNRLWHSb2Bke46cZTB-QTgOhjxg-Ow-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2015-07-30 12:36 ` Sagi Grimberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BA1327.20701@dev.mellanox.co.il \
--to=sagig-ldsdmyg8hgv8yrgs2mwiifqbs+8scbdb@public.gmane.org \
--cc=dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org \
--cc=gerlitz.or-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=sagig-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.