From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sagi Grimberg Subject: Re: [PATCH 06/22] IB/iser: Fix possible bogus DMA unmapping Date: Thu, 30 Jul 2015 15:09:24 +0300 Message-ID: <55BA13F4.9090805@dev.mellanox.co.il> References: <1438243595-32288-1-git-send-email-sagig@mellanox.com> <1438243595-32288-7-git-send-email-sagig@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Or Gerlitz , Sagi Grimberg Cc: Doug Ledford , "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-rdma@vger.kernel.org On 7/30/2015 1:23 PM, Or Gerlitz wrote: > On Thu, Jul 30, 2015 at 11:06 AM, Sagi Grimberg wrote: >> If iser_initialize_task_headers() routine failed before >> dma mapping, we should not attempt to unmap in cleanup_task(). > > This fixes some specific commit? if yes, add Fixes: line, if not, is > that from day-0? This was actually caught in code stare :) This got in commit: IB/iser: Fix race between iser connection teardown and scsi TMFs Which made iser_initialize_task_headers() possibly fail if the device handle is not accessible in certain wired device catastrophic error conditions. I'll add the Fixes tag. -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html