All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Horia Geantă" <horia.geanta@freescale.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <linux-crypto@vger.kernel.org>,
	Tudor Ambarus <tudor.ambarus@freescale.com>
Subject: Re: [PATCH] crypto: caam - fix rfc4106 encap shared descriptor
Date: Thu, 30 Jul 2015 16:59:01 +0300	[thread overview]
Message-ID: <55BA2DA5.8000807@freescale.com> (raw)
In-Reply-To: <20150730134618.GA17539@gondor.apana.org.au>

On 7/30/2015 4:46 PM, Herbert Xu wrote:
> On Thu, Jul 30, 2015 at 04:39:26PM +0300, Horia Geantă wrote:
>> The encap shared descriptor was changed to use the new IV convention.
>> In the process some commands were shifted, making the output length
>> zero, caam effectively writing garbage in dst.
> 
> Thanks.
> 
>> While here, update the decap descriptor to execute the "write" commands
>> before the "read"s (as it previously was).
>> This makes sure the input fifo is drained before becoming full.
> 
> Actually, I deliberately did it that way because there was an errata
> which said that doing a skipping load concurrently with a skipping
> store may cause a hang.  Is this not the case?
> 
Indeed, there is:
A-005473 - Using SEQ FIFO LOAD SKIP and SEQ FIFO STORE SKIP
simultaneously will cause the DECO to hang.

However, the skip commands are not consecutive, there's a math command
between them (both for encap and decap descriptors).

Horia

  reply	other threads:[~2015-07-30 14:14 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30 13:39 [PATCH] crypto: caam - fix rfc4106 encap shared descriptor Horia Geantă
2015-07-30 13:46 ` Herbert Xu
2015-07-30 13:59   ` Horia Geantă [this message]
2015-07-30 14:03     ` Herbert Xu
2015-07-30 15:31       ` Horia Geantă
2015-07-30 19:11         ` [PATCH v2] " Horia Geantă
2015-07-31  7:20           ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BA2DA5.8000807@freescale.com \
    --to=horia.geanta@freescale.com \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-crypto@vger.kernel.org \
    --cc=tudor.ambarus@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.