From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?windows-1252?Q?Roger_Pau_Monn=E9?= <roger.pau@citrix.com>
Subject: Re: [PATCH for-4.6] xl/libxl: disable PV vNUMA
Date: Thu, 30 Jul 2015 17:30:58 +0200
Message-ID: <55BA4332.2060208@citrix.com>
References: <1438269159-29519-1-git-send-email-wei.liu2@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
Received: from mail6.bemta14.messagelabs.com ([193.109.254.103])
	by lists.xen.org with esmtp (Exim 4.72)
	(envelope-from <prvs=64634e9eb=roger.pau@citrix.com>)
	id 1ZKpny-0004tv-W2
	for xen-devel@lists.xenproject.org; Thu, 30 Jul 2015 15:31:35 +0000
In-Reply-To: <1438269159-29519-1-git-send-email-wei.liu2@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Wei Liu <wei.liu2@citrix.com>, Xen-devel <xen-devel@lists.xenproject.org>
Cc: Dario Faggioli <dario.faggioli@citrix.com>, Ian Jackson <ian.jackson@eu.citrix.com>, Ian Campbell <ian.campbell@citrix.com>
List-Id: xen-devel@lists.xenproject.org

El 30/07/15 a les 17.12, Wei Liu ha escrit:
> Update xl manual and disable PV vNUMA in libxl.
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> ---
> Cc: Ian Campbell <ian.campbell@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Dario Faggioli <dario.faggioli@citrix.com>
> ---
>  docs/man/xl.cfg.pod.5      | 4 ++++
>  tools/libxl/libxl_create.c | 9 +++++++++
>  2 files changed, 13 insertions(+)
> 
> diff --git a/docs/man/xl.cfg.pod.5 b/docs/man/xl.cfg.pod.5
> index c78c3ba..782106c 100644
> --- a/docs/man/xl.cfg.pod.5
> +++ b/docs/man/xl.cfg.pod.5
> @@ -261,6 +261,10 @@ Specify virtual NUMA configuration with positional arguments. The
>  nth B<VNODE_SPEC> in the list specifies the configuration of nth
>  virtual node.
>  
> +Note that virtual NUMA for PV guest is not yet supported, because
> +there is issue with regard to cpuid handling that affects PV virtual
           ^ an   ^regarding
> +NUMA.
> +
>  Each B<VNODE_SPEC> is a list, which has a form of
>  "[VNODE_CONFIG_OPTION,VNODE_CONFIG_OPTION, ... ]"  (without quotes).
>  
> diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
> index 4f2f50b..4f4273d 100644
> --- a/tools/libxl/libxl_create.c
> +++ b/tools/libxl/libxl_create.c
> @@ -860,6 +860,15 @@ static void initiate_domain_create(libxl__egc *egc,
>          goto error_out;
>      }
>  
> +    /* PV vNUMA is not yet supported because there is issue with
> +     * regard to cpuid handling.

Same.

> +     */
> +    if (d_config->c_info.type == LIBXL_DOMAIN_TYPE_PV &&
> +        d_config->b_info.num_vnuma_nodes) {
> +        LOG(ERROR, "PV vNUMA not yet supported");
> +        goto error_out;
> +    }
> +
>      ret = libxl__domain_create_info_setdefault(gc, &d_config->c_info);
>      if (ret) {
>          LOG(ERROR, "Unable to set domain create info defaults");
>