Re: [PATCH v5 13/22] xen/arm: ITS: Implement gic_is_lpi helper function

[Julien Grall <julien.grall@citrix.com>]

Hi Vijay,

On 27/07/15 12:11, vijay.kilari@gmail.com wrote:
> diff --git a/xen/include/asm-arm/gic.h b/xen/include/asm-arm/gic.h
> index a9a5874..f80f291 100644
> --- a/xen/include/asm-arm/gic.h
> +++ b/xen/include/asm-arm/gic.h
> @@ -359,12 +359,14 @@ struct gic_hw_operations {
>      int (*secondary_init)(void);
>      int (*make_hwdom_dt_node)(const struct domain *d,
>                                const struct dt_device_node *node, void *fdt);
> +    bool_t (*is_lpi)(unsigned int irq);

I would much prefer to see a new field nr_lpis in the gic_info structure
and get the check directly in gic_is_lpi.

>  };
>  
>  void register_gic_ops(const struct gic_hw_operations *ops);
>  int gic_make_hwdom_dt_node(const struct domain *d,
>                             const struct dt_device_node *node,
>                             void *fdt);
> +bool_t gic_is_lpi(unsigned int irq);
>  
>  #endif /* __ASSEMBLY__ */
>  #endif
> 

Regards,

-- 
Julien Grall