From mboxrd@z Thu Jan 1 00:00:00 1970 From: Hauke Mehrtens Date: Thu, 30 Jul 2015 19:34:28 +0200 Subject: [PATCH] b43: fix extpa_gain check for 2GHz In-Reply-To: References: <1438205790-17629-1-git-send-email-hauke@hauke-m.de> <8738065hkb.fsf@kamboji.qca.qualcomm.com> Message-ID: <55BA6024.4000307@hauke-m.de> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Kalle Valo Cc: "linux-wireless@vger.kernel.org" , b43-dev On 07/30/2015 08:54 AM, Rafa? Mi?ecki wrote: > On 30 July 2015 at 07:40, Kalle Valo wrote: >> Hauke Mehrtens writes: >> >>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from >>> the 5GHz band was checked. this patch makes it check the property from >>> the correct band. >>> >>> Signed-off-by: Hauke Mehrtens >> >> Is this a regression? If yes, please add a Fixes line. >> >> Should this go to 4.2? > > Not a regression. It's like this for a loooong time. > > AFAIK PCI(e) cards don't have external power amplifier, so this code > is most likely used for some fancy SoCs only. There are 3 known SoCs > with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0. > > So we may consider taking it for 4.2 without any "Fixes: " line but I > wouldn't care too much about Cc-ing stable. > > Hauke: do you agree? > Yes, I do not have a device I know of which is affected by this error, I just saw this while looking at code close by. Just put this into the next Linux version and not to stable. Hauke From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from hauke-m.de ([5.39.93.123]:37476 "EHLO hauke-m.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753709AbbG3Reb (ORCPT ); Thu, 30 Jul 2015 13:34:31 -0400 Message-ID: <55BA6024.4000307@hauke-m.de> (sfid-20150730_193440_272909_F4B1471E) Date: Thu, 30 Jul 2015 19:34:28 +0200 From: Hauke Mehrtens MIME-Version: 1.0 To: =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Kalle Valo CC: "linux-wireless@vger.kernel.org" , b43-dev Subject: Re: [PATCH] b43: fix extpa_gain check for 2GHz References: <1438205790-17629-1-git-send-email-hauke@hauke-m.de> <8738065hkb.fsf@kamboji.qca.qualcomm.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Sender: linux-wireless-owner@vger.kernel.org List-ID: On 07/30/2015 08:54 AM, Rafał Miłecki wrote: > On 30 July 2015 at 07:40, Kalle Valo wrote: >> Hauke Mehrtens writes: >> >>> On the 2GHz and and on the 5GHZ band only the extpa_gain setting from >>> the 5GHz band was checked. this patch makes it check the property from >>> the correct band. >>> >>> Signed-off-by: Hauke Mehrtens >> >> Is this a regression? If yes, please add a Fixes line. >> >> Should this go to 4.2? > > Not a regression. It's like this for a loooong time. > > AFAIK PCI(e) cards don't have external power amplifier, so this code > is most likely used for some fancy SoCs only. There are 3 known SoCs > with N-PHY rev 5 or 6: BCM4717A1, BCM4718A1 & BCM4716B0. > > So we may consider taking it for 4.2 without any "Fixes: " line but I > wouldn't care too much about Cc-ing stable. > > Hauke: do you agree? > Yes, I do not have a device I know of which is affected by this error, I just saw this while looking at code close by. Just put this into the next Linux version and not to stable. Hauke