From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Hurley Subject: Re: [PATCH] drm/nouveau/gem: tolerate a buffer specified multiple times Date: Thu, 30 Jul 2015 17:45:26 -0400 Message-ID: <55BA9AF6.6060808@hurleysoftware.com> References: <1438252085-4773-1-git-send-email-pure.logic@nexus-software.ie> <55BA3966.1050806@hurleysoftware.com> <55BA3A12.4000800@nexus-software.ie> <55BA3B21.8000603@nexus-software.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-qg0-f42.google.com (mail-qg0-f42.google.com [209.85.192.42]) by gabe.freedesktop.org (Postfix) with ESMTPS id 66FF86E47C for ; Thu, 30 Jul 2015 14:45:29 -0700 (PDT) Received: by qged69 with SMTP id d69so34067189qge.0 for ; Thu, 30 Jul 2015 14:45:28 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Bryan O'Donoghue , Timo Aaltonen Cc: Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Ben Skeggs , Maarten Lankhorst List-Id: dri-devel@lists.freedesktop.org WyArY2MgRGViaWFuIG1haW50YWluZXIgXQoKT24gMDcvMzAvMjAxNSAxMToyNiBBTSwgRW1pbCBW ZWxpa292IHdyb3RlOgo+IE9uIDMwIEp1bHkgMjAxNSBhdCAxNjowMiwgSWxpYSBNaXJraW4gPGlt aXJraW5AYWx1bS5taXQuZWR1PiB3cm90ZToKPj4gT24gVGh1LCBKdWwgMzAsIDIwMTUgYXQgMTA6 NTYgQU0sIEJyeWFuIE8nRG9ub2dodWUKPj4gPHB1cmUubG9naWNAbmV4dXMtc29mdHdhcmUuaWU+ IHdyb3RlOgo+Pj4gT24gMzAvMDcvMTUgMTU6NTIsIEJyeWFuIE8nRG9ub2dodWUgd3JvdGU6Cj4+ Pj4KPj4+PiBPbiAzMC8wNy8xNSAxNTo0OSwgUGV0ZXIgSHVybGV5IHdyb3RlOgo+Pj4+Pgo+Pj4+ PiBPbiAwNy8zMC8yMDE1IDEwOjEyIEFNLCBJbGlhIE1pcmtpbiB3cm90ZToKPj4+Pj4+Cj4+Pj4+ PiBJcyB0aGlzIGhhcHBlbmluZyB3aXRoIGxpYmRybSAyLjQuNjA/IElmIHNvLCB0aGF0J3MgYSBr bm93bgo+Pj4+Pj4gKHVzZXItc2lkZSkgaXNzdWUgYW5kIHNob3VsZCBiZSBmaXhlZCBieSB1c2lu ZyBhbnkgdmVyc2lvbiBidXQgdGhhdAo+Pj4+Pj4gb25lLgo+Pj4+Pgo+Pj4+Pgo+Pj4+PiBXaGF0 J3MgdGhlIGZyZWVkZXNrdG9wIGJ1Z3ppbGxhICMgZm9yIHJlZmVyZW5jZT8KPj4+Pj4KPj4+Pj4g UmVnYXJkcywKPj4+Pj4gUGV0ZXIgSHVybGV5Cj4+Pj4KPj4+Pgo+Pj4+IEkgYmVsaWV2ZSBpdCdz IHRoaXMgb25lCj4+Pj4KPj4+PiBodHRwczovL2J1Z3MuZnJlZWRlc2t0b3Aub3JnL3Nob3dfYnVn LmNnaT9pZD04OTg0MiNjMTkKPj4+Pgo+Pj4KPj4+IE5vdCByZWFsbHkgYSB3b3JsZCBvZiBjaG9p Y2Ugb24gdWJ1bnR1IHRvIGZpeCBpdCB0aG91Z2guLi4KPj4+Cj4+PiBkZWNrYXJkQGFpbmVrbzp+ L0RldmVsb3BtZW50L3Byb2plY3RhcmEkIGFwdC1zaG93LXZlcnNpb25zIGxpYmRybTIKPj4+IGxp YmRybTI6YW1kNjQvdHJ1c3R5LXVwZGF0ZXMgMi40LjYwLTJ+dWJ1bnR1MTQuMDQuMSB1cHRvZGF0 ZQo+Pj4gbGliZHJtMjppMzg2L3RydXN0eS11cGRhdGVzIDIuNC42MC0yfnVidW50dTE0LjA0LjEg dXB0b2RhdGUKPj4+Cj4+PiA6KAo+Pgo+PiBUaGF0J3MgdW5mb3J0dW5hdGUuIEkga25vdyBuZXh0 IHRvIG5vdGhpbmcgYWJvdXQgZGViaWFuL3VidW50dSBvciBob3cKPj4gdGhleSBkbyB2ZXJzaW9u cyBvciBob3cgdG8gZXZlbiBidWlsZCBwYWNrYWdlcyBmb3IgdGhlbS4gQnV0IHRoZXkncmUKPj4g YmlnIGRpc3Ryb3MsIHByZXN1bWFibHkgdGhleSBoYXZlIHN1cHBvcnQgdGVhbXMgb2Ygc29tZSBz b3J0LCBwZXJoYXBzCj4+IHRoZXkgY2FuIGhlbHAgeW91Lgo+Pgo+PiBBc3N1bWluZyB0aGF0IHN3 aXRjaGluZyBhd2F5IGRvZXMgcmVzb2x2ZSB0aGUgaXNzdWUgZm9yIHlvdSwgcGVyaGFwcwo+PiB5 b3UgY2FuIGFsc28gcmVjb21tZW5kIHRoYXQgdGhleSBhdm9pZCBzaGlwcGluZyB0aGF0IHZlcnNp b24sIG9yCj4+IGluY2x1ZGUgdGhpcyBub3V2ZWF1IGZpeCBpbiBpdDoKPj4KPj4gaHR0cDovL2Nn aXQuZnJlZWRlc2t0b3Aub3JnL21lc2EvZHJtL2NvbW1pdC8/aWQ9ODEyZThmZTZjZTQ2ZDczM2Mz MDIwN2VlMjZjNzg4YzYxZjU0NjI5NAo+Pgo+IEZ3aXcgZGViaWFuIGhhcyBiZWVuIHRyYWNraW5n IHRoaXMgYXMgIzc4OTc1OSwgYW5kIHRoZXkgYXJlIHNoaXBwaW5nCj4gMi40LjYyIHdoaWNoIGlu Y2x1ZGVzIHRoZSBmaXguCgpVbmZvcnR1bmF0ZWx5IHRoZSBMVFMgdmVyc2lvbiBvZiBVYnVudHUg KHRydXN0eSkgd2FzIHVwZGF0ZWQgdG8gMi40LjYwCnNldmVyYWwgZGF5cyBhZ28gd2l0aG91dCB0 aGlzIGZpeC4KCkkgcmVwYWNrYWdlZCBsaWJkcm0gMi40LjYwIHdpdGggb25seSB0aGUgYnVnIGZp eCBhYm92ZSBhbmQgY29uZmlybSB0aGUKcGF0Y2ggYWJvdmUgZml4ZXMgdGhlIG9ic2VydmVkIGJl aGF2aW9yIGluIGZyZWVkZXNrdG9wIGJ1ZyMgODk4NDIvCmRlYmlhbiBidWcjIDc4OTc1OS4KCkkg cHVzaGVkIHRoZSByZXBhY2thZ2UgdG8gTGF1bmNocGFkIFBQQSBAIHBwYTpwaHVybGV5L2xpYmRy bQoKSG9wZWZ1bGx5IHRoZSBEZWJpYW4gbWFpbnRhaW5lciBncmFicyB0aGlzIGZpeCBhbmQgdXBk YXRlcyB0aGUgb2ZmaWNpYWwKZGlzdHJpYnV0aW9uIHZlcnNpb24gc29vbi4KClJlZ2FyZHMsClBl dGVyIEh1cmxleQpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752180AbbG3Vpa (ORCPT ); Thu, 30 Jul 2015 17:45:30 -0400 Received: from mail-qg0-f54.google.com ([209.85.192.54]:35293 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751263AbbG3Vp3 (ORCPT ); Thu, 30 Jul 2015 17:45:29 -0400 Message-ID: <55BA9AF6.6060808@hurleysoftware.com> Date: Thu, 30 Jul 2015 17:45:26 -0400 From: Peter Hurley User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Bryan O'Donoghue" , Timo Aaltonen CC: Emil Velikov , Ilia Mirkin , Maarten Lankhorst , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Ben Skeggs Subject: Re: [PATCH] drm/nouveau/gem: tolerate a buffer specified multiple times References: <1438252085-4773-1-git-send-email-pure.logic@nexus-software.ie> <55BA3966.1050806@hurleysoftware.com> <55BA3A12.4000800@nexus-software.ie> <55BA3B21.8000603@nexus-software.ie> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org [ +cc Debian maintainer ] On 07/30/2015 11:26 AM, Emil Velikov wrote: > On 30 July 2015 at 16:02, Ilia Mirkin wrote: >> On Thu, Jul 30, 2015 at 10:56 AM, Bryan O'Donoghue >> wrote: >>> On 30/07/15 15:52, Bryan O'Donoghue wrote: >>>> >>>> On 30/07/15 15:49, Peter Hurley wrote: >>>>> >>>>> On 07/30/2015 10:12 AM, Ilia Mirkin wrote: >>>>>> >>>>>> Is this happening with libdrm 2.4.60? If so, that's a known >>>>>> (user-side) issue and should be fixed by using any version but that >>>>>> one. >>>>> >>>>> >>>>> What's the freedesktop bugzilla # for reference? >>>>> >>>>> Regards, >>>>> Peter Hurley >>>> >>>> >>>> I believe it's this one >>>> >>>> https://bugs.freedesktop.org/show_bug.cgi?id=89842#c19 >>>> >>> >>> Not really a world of choice on ubuntu to fix it though... >>> >>> deckard@aineko:~/Development/projectara$ apt-show-versions libdrm2 >>> libdrm2:amd64/trusty-updates 2.4.60-2~ubuntu14.04.1 uptodate >>> libdrm2:i386/trusty-updates 2.4.60-2~ubuntu14.04.1 uptodate >>> >>> :( >> >> That's unfortunate. I know next to nothing about debian/ubuntu or how >> they do versions or how to even build packages for them. But they're >> big distros, presumably they have support teams of some sort, perhaps >> they can help you. >> >> Assuming that switching away does resolve the issue for you, perhaps >> you can also recommend that they avoid shipping that version, or >> include this nouveau fix in it: >> >> http://cgit.freedesktop.org/mesa/drm/commit/?id=812e8fe6ce46d733c30207ee26c788c61f546294 >> > Fwiw debian has been tracking this as #789759, and they are shipping > 2.4.62 which includes the fix. Unfortunately the LTS version of Ubuntu (trusty) was updated to 2.4.60 several days ago without this fix. I repackaged libdrm 2.4.60 with only the bug fix above and confirm the patch above fixes the observed behavior in freedesktop bug# 89842/ debian bug# 789759. I pushed the repackage to Launchpad PPA @ ppa:phurley/libdrm Hopefully the Debian maintainer grabs this fix and updates the official distribution version soon. Regards, Peter Hurley