From: Peter Hurley <peter@hurleysoftware.com>
To: John Ogness <john.ogness@linutronix.de>, linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Tony Lindgren <tony@atomide.com>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
linux-omap@vger.kernel.org, nsekhar@ti.com, nm@ti.com,
linux-serial@vger.kernel.org
Subject: Re: [PATCH 1/3] serial: 8250: unlock port for uart_write_wakeup()
Date: Thu, 30 Jul 2015 19:15:23 -0400 [thread overview]
Message-ID: <55BAB00B.3010806@hurleysoftware.com> (raw)
In-Reply-To: <87h9ol2r4y.fsf@linutronix.de>
On 07/30/2015 06:54 PM, John Ogness wrote:
> uart_write_wakeup() should be called without holding the port lock.
> Otherwise a possible recursive spinlock issue can occur, such as
> the following callchain:
>
> 8250_core.c:serial8250_tx_chars() - called with port locked
> serial_core.c:uart_write_wakeup()
> tty_io.c:tty_wakeup()
> st_core.c:st_tty_wakeup()
> st_core.c:st_tx_wakeup()
> st_core.c:st_int_write()
> serial_core.c:uart_write() - locks port
NAK.
This is a bug in the N_TI_WL line discipline, specifically in the
st_tx_wakeup() function, which cannot perform the write synchronously.
This is a common line discipline bug, and typically fixed by performing
the wakeup operations from a kworker instead.
Regards,
Peter Hurley
next prev parent reply other threads:[~2015-07-30 23:15 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 22:54 [PATCH 1/3] serial: 8250: unlock port for uart_write_wakeup() John Ogness
2015-07-30 22:54 ` John Ogness
2015-07-30 23:15 ` Peter Hurley [this message]
2015-07-30 23:53 ` Peter Hurley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BAB00B.3010806@hurleysoftware.com \
--to=peter@hurleysoftware.com \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.