From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [59.151.112.132] (helo=heian.cn.fujitsu.com)
 by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux))
 id 1ZKxtD-0000sh-8x
 for linux-mtd@lists.infradead.org; Fri, 31 Jul 2015 00:09:31 +0000
Message-ID: <55BABB55.6010807@cn.fujitsu.com>
Date: Fri, 31 Jul 2015 08:03:33 +0800
From: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
MIME-Version: 1.0
To: Brian Norris <computersforpeace@gmail.com>
CC: <richard.weinberger@gmail.com>, <dedekind1@gmail.com>,
 <linux-mtd@lists.infradead.org>
Subject: Re: [PATCH 1/2] ubifs: Kconfig: fix the description in Kconfig
References: <1435728600-14560-1-git-send-email-yangds.fnst@cn.fujitsu.com>
 <20150730164701.GA42191@google.com>
In-Reply-To: <20150730164701.GA42191@google.com>
Content-Type: text/plain; charset="ISO-8859-1"; format=flowed
Content-Transfer-Encoding: 7bit
List-Id: Linux MTD discussion mailing list <linux-mtd.lists.infradead.org>
List-Unsubscribe: <http://lists.infradead.org/mailman/options/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=unsubscribe>
List-Archive: <http://lists.infradead.org/pipermail/linux-mtd/>
List-Post: <mailto:linux-mtd@lists.infradead.org>
List-Help: <mailto:linux-mtd-request@lists.infradead.org?subject=help>
List-Subscribe: <http://lists.infradead.org/mailman/listinfo/linux-mtd>,
 <mailto:linux-mtd-request@lists.infradead.org?subject=subscribe>

On 07/31/2015 12:47 AM, Brian Norris wrote:
> On Wed, Jul 01, 2015 at 01:29:59PM +0800, Dongsheng Yang wrote:
>> If unsure we would say 'N' rather than 'Y'.
>>
>> Signed-off-by: Dongsheng Yang <yangds.fnst@cn.fujitsu.com>
>> ---
>>   fs/ubifs/Kconfig | 4 ++--
>>   1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ubifs/Kconfig b/fs/ubifs/Kconfig
>> index ba66d50..f9aaad1 100644
>> --- a/fs/ubifs/Kconfig
>> +++ b/fs/ubifs/Kconfig
>> @@ -27,11 +27,11 @@ config UBIFS_FS_LZO
>>   	default y
>>   	help
>>   	   LZO compressor is generally faster than zlib but compresses worse.
>> -	   Say 'Y' if unsure.
>> +	   Say 'N' if unsure.
>
> Why would we recommend 'N' yet set the default to 'Y'? Seems like
> some dissonance.

OMG, that's TRUE. I can not recall what I was thinking when I sent
this patch, but I believe there was something wrong in my mind.

Thanx a lot to point it out, Brian.

Atem and Richard, Please ignore this noise. My bad :(.

Yang
>
> Also, I'm not an expert on UBIFS, but I imagine the suggestion to say
> yes is because of legacy support; what if you need to mount a file
> system that was created with LZO?
>
>>
>>   config UBIFS_FS_ZLIB
>>   	bool "ZLIB compression support" if UBIFS_FS_ADVANCED_COMPR
>>   	depends on UBIFS_FS
>>   	default y
>>   	help
>> -	  Zlib compresses better than LZO but it is slower. Say 'Y' if unsure.
>> +	  Zlib compresses better than LZO but it is slower. Say 'N' if unsure.
>
> Same here.
>
> Brian
> .
>