From mboxrd@z Thu Jan 1 00:00:00 1970 From: Taichi Kageyama Subject: Re: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console Date: Fri, 31 Jul 2015 07:02:26 +0000 Message-ID: <55BB1D82.909@cp.jp.nec.com> References: <1438157443-19447-1-git-send-email-t-kageyama@cp.jp.nec.com> <55B8BE39.6080500@hurleysoftware.com> <55B8D26A.7000402@hurleysoftware.com> <55B980E6.70800@cp.jp.nec.com> <55BA2A06.1080109@hurleysoftware.com> <55BAB6B5.2090908@hurleysoftware.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <55BAB6B5.2090908@hurleysoftware.com> Content-Language: ja-JP Content-ID: <5927DFD3B67E0D41A75018A5F183FF65@gisp.nec.co.jp> Sender: linux-kernel-owner@vger.kernel.org To: Peter Hurley , Thomas Gleixner Cc: "gregkh@linuxfoundation.org" , "jiang.liu@linux.intel.com" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jslaby@suse.cz" , "prarit@redhat.com" , Naoya Horiguchi , Peter Zijlstra List-Id: linux-serial@vger.kernel.org T24gMjAxNS8wNy8zMSA4OjQzLCBQZXRlciBIdXJsZXkgd3JvdGU6DQo+IE9uIDA3LzMwLzIwMTUg MDY6MTIgUE0sIFRob21hcyBHbGVpeG5lciB3cm90ZToNCj4+IE9uIFRodSwgMzAgSnVsIDIwMTUs IFBldGVyIEh1cmxleSB3cm90ZToNCj4+PiBIb25lc3RseSwgSSdtIG5vdCB0b28gc3VyZSB0aGlz IGlzIHRoZSB3YXkgdG8gZ28uDQo+Pj4NCj4+PiBNZXNzaW5nIGFyb3VuZCB3aXRoIGlycXNvZmYg dHJhY2VyIGZvciAzMCBtaW5zIHR1cm5lZCB1cDoNCj4+PiAzLjY2NG1zIGluIGludGVsX3VubWFw X3BhZ2UNCj4+PiAgIC0gaW90bGIgZmx1c2gsIHNwaW5sb2NrIGNvbnRlbnRpb24gb24gaW92YV9y YnRyZWVfbG9jaw0KPj4+IDEuNzI2bXMgaW4gaW50ZWxfbWFwX3BhZ2UoKQ0KPj4+ICAgLSBpb21t dSBjb3JlIEAgX19hbGxvY19hbmRfaW5zZXJ0X2lvdmFfcmFuZ2UoKQ0KPj4+IDEuODU5bXMgaW4g c3lzbG9nX3ByaW50X2FsbCgpDQo+Pj4gICAtIHdoaWNoIGlzIGhvbGRpbmcgdGhlIGxvZ2J1Zl9s b2NrIHNvIHRoYXQncyBwcmV0dHkgYmFkIGFueXdheQ0KPj4+IDM4N3VzIGluIG5vdXZlYXUgQCBu djUwX3ZtX2ZsdXNoKCkNCj4+PiAgIC0gZ3B1IHRsYiBmbHVzaA0KPj4+DQo+Pj4gSSBoYXZlIGly cXNvZmYgdHJhY2UgcmVwb3J0cyBmb3IgYWxsIG9mIHRoZXNlIGlmIGFueW9uZSBpcyBpbnRlcmVz dGVkLg0KPj4+DQo+Pj4gTG9va3MgbGlrZSBsb2NrZGVwIHdvdWxkIG5lZWQgdG8gYmUgb2ZmIGFz IHdlbGwgYmVjYXVzZSBJIHNhdyBidXQNCj4+PiBmYWlsZWQgdG8gY2FwdHVyZSBhIHNhdmVfdHJh Y2UoKSBpbiB0aGUgMzAwdXMgcmFuZ2UuDQo+Pj4NCj4+PiBJIHRoaW5rIHRoaXMgaXMganVzdCB0 aGUgdGlwIG9mIHRoZSBpY2ViZXJnIGZvciBpcnFzb2ZmLg0KPj4NCj4+IEkgYWdyZWUuDQo+PiAg DQo+Pj4gSSdtIG5vdCBzYXlpbmcgdGhlc2UgZG9uJ3QgbmVlZCBmaXhpbmcgYXMgd2VsbCwgYnV0 IHRoZXJlJ3Mgbm8gd2F5DQo+Pj4gaXJxIHByb2JlIHdpbGwgZXZlciBiZSByZWxpYWJsZSB3aXRo IHRoaXMgYXBwcm9hY2guDQo+Pg0KPj4gaXJxIHByb2JlIGlzIGEga25vd24gdG8gYmUgdW5yZWxp YWJsZSBoZXVyaXN0aWMgZW5kYXZvdXIgYW55d2F5IGFuZCBpdA0KPj4gY2Fubm90IGV2ZXIgYmVj b21lIHRydWx5IHJlbGlhYmxlLCBleGNlcHQgeW91IHB1dCBhIGdhemlsbGlvbiBvZg0KPj4gcmVz dHJpY3Rpb25zIHRvIHRoZSBzeXN0ZW0gc3RhdGUgb24gaXQuDQo+IA0KPiBZZXAsIHRvdGFsbHkg YWdyZWUuIEFzIHlvdSBub3RlIGJlbG93LCB0aGlzIGZ1bmN0aW9uYWxpdHkgaXMgY29tcGxldGVs eQ0KPiBkaXNhYmxlZCBvbiBldmVyeSBrbm93biBkaXN0cm8ga2VybmVsLg0KPiANCj4gDQo+Pj4g R29pbmcgYmFjayB0byB0aGUgUkZDIGlkZWEgb2YgcGlubmluZyB0aGUgaXJxIGFmZmluaXR5IHRv IHRoZSBjcHUNCj4+PiBhY3R1YWxseSBkb2luZyB0aGUgcHJvYmluZyAod2hpY2ggaXMgaW4gYSBr bm93biBjb250ZXh0KSwgd2hhdCBhYm91dA0KPj4+IHRoYXQgaXMgYnJva2VuIG9uIFVQPyBKdXN0 IHRoZSBpbXBsZW1lbnRhdGlvbiBvciBpcyBpdCB0aGUgZnVuZGFtZW50YWwNCj4+PiBjb25jZXB0 Pw0KPj4NCj4+IEZpcnN0IG9mIGFsbCwgdGhlcmUgaXMgbm8gZ3VhcmFudGVlIHRoYXQgeW91IGNh biBhZmZpbmUgdGhlc2UNCj4+IGludGVycnVwdHMgYXQgYWxsLiBXZSBoYXZlIGludGVycnVwdCBj b250cm9sbGVycyB3aGljaCBjYW5ub3Qgc2V0IHRoZQ0KPj4gYWZmaW5pdHkgYW5kIHRoZXkgZGVs aXZlciB0byBjcHVzIGluIGEgcm91bmQgcm9iaW4gc2NoZW1lIG9yIHdoYXRldmVyDQo+PiBoYXJk d2FyZSBkZXNpZ25lcnMgdGhvdWdodCB3b3VsZCBiZSBjbGV2ZXIuDQo+Pg0KPj4gU2Vjb25kLCB3 aGF0IHByZXZlbnRzIHRoZSBmb2xsb3dpbmcgc2NlbmFyaW8gb24gVVAgb3IgdGhlIGFmZmluZSBj b3JlOg0KPj4NCj4+IAlwcm9iZV9zdGFydCgpDQo+PiAJaW50ZXJydXB0DQo+PiAJICBsb29vbmcg cnVubmluZyBoYW5kbGVyICh1c2IgaXMgYW4gb2J2aW91cyBjYW5kaWRhdGUpDQo+PiAJICAgICBw cmludGsoKQ0KPj4NCj4+IFRoYXQgd2lsbCBzd2FsbG93IHlvdXIgdWFydCBzdGF0ZSBhbmQgcnVp biBkZXRlY3Rpb24gYXMgd2VsbC4NCg0KDQpZZXMsIHRoZSBSRkMgaWRlYSB3YXMganVzdCBmb3Ig cmVkdWNpbmcgdGhlIHJpc2sgb2YgZmFpbHVyZSwgbm90IHBlcmZlY3QuDQpJIGtub3cgaXQgZGVw ZW5kcyBvbiB0aGUgaW50ZXJydXB0IGNvbnRyb2xsZXJzLA0KYnV0IEkgZGlkbid0IGtub3cgdGhl IGVycm9yIG9jY3VycmVkIGFmdGVyIG90aGVycyBzZXQgYWZmaW5pdHkuDQpJIHVuZGVyc3RhbmQg dGhlcmUgaXMgbm8gZ3VhcmFudGVlIGF0IGFsbCBpbiBteSBSRkMgY2FzZS4NCg0KPiBZZWFoLCBv aywgc28gZnVuZGFtZW50YWxseSBicm9rZW4gY29uY2VwdCB0byBwaW4gdGhlIGlycXMgZm9yIHBy b2JpbmcuDQo+IFRoYW5rcyBmb3IgY2xhcmlmeWluZyB0aGF0Lg0KPiANCj4gDQo+PiBTbyBmb3Ig dGhlIHByb2JsZW0gYXQgaGFuZCwgd2UgcmVhbGx5IG5lZWQgdG8gcHJldmVudCB0aGF0IHNvbWV0 aGluZw0KPj4gaXMgZmlkZGxpbmcgd2l0aCB0aGUgdWFydCBpbiB0aGUgZmlyc3QgcGxhY2UgYW5k IHRoZSBtb3N0IG9idmlvdXMgd2F5DQo+PiBpcyB0byBzZXJpYWxpemUgYWdhaW5zdCBwcmludGsu DQo+IA0KPiBJJ20gb2sgd2l0aCBqdXN0IHRoZSBvcmlnaW5hbCBwYXRjaCAxICh3aGljaCBJIHJl dmlld2VkIHNvbWUgdGltZSBhZ28pLg0KPiANCj4gDQo+PiBXZSBjYW4gZGViYXRlIHdoZXRoZXIg dGhlIGF1dG9wcm9iZSBjb2RlIGlzIHRoZSByaWdodCBwbGFjZSBvciBub3QsIHdlDQo+PiBjYW4g YWN0dWFsbHkgc3RpY2sgaXQgaW50byB0aGUgODI1MCBkcml2ZXIgYW5kIGJlIGRvbmUgd2l0aCBp dA0KPj4gYmVjYXVzZToNCj4+DQo+PiBJZiB5b3UgbG9vayBhdCB0aGUgYWN0dWFsIGF1dG9wcm9i ZSB1c2VycyBhc2lkZSBvZiA4MjUwLiBUaGF0J3MgcmVhbGx5DQo+PiBhbGwgYW5jaWVudCBJU0Eg aGFyZHdhcmUgYW5kIGhhcmRseSBpbnRlcmVzdGluZy4gU28gYWxsIHdlIHJlYWxseSBjYXJlDQo+ PiBhYm91dCBhcmUgdGhlIDgyNTAgc2VyaWFsIHBvcnRzLg0KDQpJbiB0aGlzIGNhc2UsIEkgdGhp bmsgW3BhdGNoIHYyIDEvM10gaXMgZW5vdWdoLg0KY29uc29sZV9sb2NrIGlzIHJlcXVpcmVkIGlu IGF1dG9jb25maWdfaXJxKCkgdG8gcmVzb2x2ZSBvdGhlciByYWNlIGNvbmRpdGlvbnMNCmJlZm9y ZSBjYWxsaW5nIHByb2JlX2lycV9vbigpLg0KDQo+Pg0KPj4gTm93IGxldHMgbG9vayBhdCB0aGUg ODI1MCBzZXJpYWwgcG9ydHMuIEkganVzdCBjaGVja2VkIHRoZSByYW5kb20NCj4+IGNvbGxlY3Rp b24gb2YgbWFjaGluZXMgSSBoYXZlIGFjY2VzcyB0bzoNCj4+DQo+PiAgSW4gMTAwJSBvZiBhbGwg Y2FzZXMgdHR5UzAgaXMgb24gaXJxNCBhbmQgdHR5UzEgaXMgb24gaXJxMw0KPj4NCj4+ICBBbGwg b2YgdGhlIG1hY2hpbmVzIGhhdmUgZXZlbiBhIGNvcnJlY3QgUE5QIGVudHJ5IG9mIHRoZSBpcnEg cmVzb3VyY2UNCj4+ICBmb3IgdGhlIHNlcmlhbCBwb3J0cy4gQW5kIHRoZXJlIGlzIHByZXR0eSBv bGQgY3JhcCBpbiB0aGF0IGxvdC4NCj4+DQo+PiBTbyB0aGUgcmVhbCBxdWVzdGlvbiBpczogV2h5 IHdvdWxkIHdlIGF1dG9wcm9iZSBpbiB0aGUgZmlyc3QgcGxhY2U/DQo+Pg0KPj4gRGViaWFuLCBG ZWRvcmEsIE9wZW5TdXNlLCBTTEVTIGhhdmU6DQo+Pg0KPj4gICAgIyBDT05GSUdfU0VSSUFMXzgy NTBfREVURUNUX0lSUSBpcyBub3Qgc2V0DQo+Pg0KPj4gYW5kIHNvIGRvIG15IGtlcm5lbHMuDQo+ PiBJIGp1c3QgYnVpbHQgb25lIHdpdGggdGhhdCBvcHRpb24gZW5hYmxlZCBmb3IgdGhlIGZ1biBv ZiBpdCBhbmQgaXQNCj4+IHN0aWxsIHVzZXMgdGhlIFBOUCBpbmZvcm1hdGlvbi4gTm8gYXV0b3By b2JpbmcuDQo+Pg0KPj4gU28gd2h5IGFyZSB5b3UgaW50ZXJlc3RlZCBpbiB0aGF0IHNlcmlhbCBp cnEgYXV0b3Byb2JlIGNyYXAgYXQgYWxsPw0KPiANCg0KQmVjYXVzZSBSSEVMNiB1c2VzIENPTkZJ R19TRVJJQUxfODI1MF9ERVRFQ1RfSVJRPXkgdW5mb3J0dW5hdGVseS4NCg0KPiBBZ3JlZSwgYnV0 IEkgZ3Vlc3MgdGhlIGhhcmR3YXJlIGluIHF1ZXN0aW9uIGlzIG5vbi1QTlAgc2VyaWFsLW92ZXIt TEFOLg0KPiBJdCdzIFRhaWNoaSdzIGhhcmR3YXJlIHNvIGhlIGNhbiBiZSBtb3JlIHNwZWNpZmlj LiBBbHNvLCB0aGlzIHByb2JsZW0NCj4gd291bGQgbm90IGFwcGx5IHRvIDgyNTAgcG9ydHMgQCB0 aGUgSVNBIGFkZHJlc3NlcyAoM2Y4LGlycSA0ICYgMmY4LGlycSAzKQ0KPiBiZWNhdXNlIHRob3Nl IGFyZSBwcmVkZWZpbmVkIG9uIHRoZSBwbGF0Zm9ybS4NCj4gDQo+IFRhaWNoaSdzIG9yaWdpbmFs IHByb3Bvc2FsIHdhcyB0byBhZGQgbW9kdWxlIHBhcmFtZXRlcnMgZm9yIHRoZSBzZXJpYWwNCj4g ZHJpdmVyLCB3aGljaCBJIGFtIGRlYWQgc2V0IGFnYWluc3QsIGhhdmluZyBqdXN0IHN0cnVnZ2xl ZCB0byBkZWFsIHdpdGgNCj4gYW5jaWVudCBtb2R1bGUgcGFyYW1ldGVycyB3aGlsZSBzcGxpdHRp bmcgdGhlIDgyNTAgZHJpdmVyLg0KDQpBcyB5b3UgZ3V5cyBtZW50aW9uZWQsIGlycTMgYW5kIDQg Zm9yIGNvbnNvbGUgcG9ydHMgYXJlIHByZWRlZmluZWQgYmFzaWNhbGx5Lg0KVGhhdCdzIHdoeSBJ IGludHJvZHVjZWQgb3JpZ2luYWwgcGF0Y2ggdG8gc2tpcCBhdXRvY29uZmlnX2lycSBvbmx5IGZv ciBjb25zb2xlDQphbHRob3VnaCB0aGUgcGFyYW1ldGVyIHRoaW5nIHdhcyBub3QgZ29vZCBpZGVh Lg0KSSdtIHVzaW5nIG9uZSBvZiB2ZXJ5IGxhcmdlIEhQIHBsYXRmb3JtLg0KSXQgZXhwZWN0cyBJ U0EgYWRkcmVzc2VzIGZvciBTT0wsIGJ1dCBkb2Vzbid0IHByb3ZpZGVzIFBOUCBkZWZpbmUgbGlr ZSBQTlAwNTAxLg0KU28gYXV0b2NvbmZpZ19pcnEoKSBjYW4gb3ZlcndyaXRlcyB2YWxpZCBpcnEg d2l0aCBpbnZhbGlkIG9uZS4uLg0KDQoNCj4gSSBhbHNvIG5vdGVkIGluIHJldmlld2luZyB0aGF0 IHByb3Bvc2FsIHRoYXQgdXNlci1zcGFjZSB0b29scyAoc2V0c2VyaWFsKQ0KPiBjYW4gcmVzZXQg dGhlIGlycSB0byBhIGtub3duIHZhbHVlIGFmdGVyIGRyaXZlciBsb2FkLiBVYnVudHUsIGZvciBv bmUsDQo+IHJ1bnMgc2V0c2VyaWFsIGFzIHBhcnQgb2YgYm9vdCAodG8gcmVzdG9yZSBzZXJpYWwg aGFyZHdhcmUgdG8ga25vd24td29ya2luZw0KPiBjb25maWd1cmF0aW9uKS4NCg0KSSBhbHJlYWR5 IGdvdCB0aGUgZm9sbG93aW5nIGNvbnNvbGUgc29sdXRpb25zIGFmdGVyIGRpc2N1c3Npb24gd2l0 aCBQZXRlci4NCiAtIEZvcmNlIHNldCBpcnEgYmVmb3JlIGFueSBBUHMgYW5kIGdldHR5IG9wZW4g L2Rldi9jb25zb2xlLiANCiAgIFVzZXJzIGhhdmUgdG8ga25vdyB2YWxpZCBpcnEjLg0KIC0gRml4 IEZXIHRvIGRlZmluZSBQTlANCiAtIENPTkZJR19TRVJJQUxfODI1MF9ERVRFQ1RfSVJRPW4NCg0K DQpUaGFua3MsDQpUYWljaGkNCg0K From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751989AbbGaHEh (ORCPT ); Fri, 31 Jul 2015 03:04:37 -0400 Received: from TYO201.gate.nec.co.jp ([210.143.35.51]:52654 "EHLO tyo201.gate.nec.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751711AbbGaHEe (ORCPT ); Fri, 31 Jul 2015 03:04:34 -0400 From: Taichi Kageyama To: Peter Hurley , Thomas Gleixner CC: "gregkh@linuxfoundation.org" , "jiang.liu@linux.intel.com" , "linux-serial@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "jslaby@suse.cz" , "prarit@redhat.com" , Naoya Horiguchi , Peter Zijlstra Subject: Re: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console Thread-Topic: [RFC PATCH v2 0/3] genirq, serial: 8250: Workaround to avoid irq=0 for console Thread-Index: AQHQydZbScPgUgU8AkiRV4IVadm+W53xqVSAgAAV5YCAAAC0AIAAF14AgAAFFgCAAMrqAIAAjqOAgAA6+gCAAI47AIAAGXqAgAB6jQA= Date: Fri, 31 Jul 2015 07:02:26 +0000 Message-ID: <55BB1D82.909@cp.jp.nec.com> References: <1438157443-19447-1-git-send-email-t-kageyama@cp.jp.nec.com> <55B8BE39.6080500@hurleysoftware.com> <55B8D26A.7000402@hurleysoftware.com> <55B980E6.70800@cp.jp.nec.com> <55BA2A06.1080109@hurleysoftware.com> <55BAB6B5.2090908@hurleysoftware.com> In-Reply-To: <55BAB6B5.2090908@hurleysoftware.com> Accept-Language: en-US, ja-JP Content-Language: ja-JP X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.34.108.73] Content-Type: text/plain; charset="utf-8" Content-ID: <5927DFD3B67E0D41A75018A5F183FF65@gisp.nec.co.jp> MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t6V74fan007096 On 2015/07/31 8:43, Peter Hurley wrote: > On 07/30/2015 06:12 PM, Thomas Gleixner wrote: >> On Thu, 30 Jul 2015, Peter Hurley wrote: >>> Honestly, I'm not too sure this is the way to go. >>> >>> Messing around with irqsoff tracer for 30 mins turned up: >>> 3.664ms in intel_unmap_page >>> - iotlb flush, spinlock contention on iova_rbtree_lock >>> 1.726ms in intel_map_page() >>> - iommu core @ __alloc_and_insert_iova_range() >>> 1.859ms in syslog_print_all() >>> - which is holding the logbuf_lock so that's pretty bad anyway >>> 387us in nouveau @ nv50_vm_flush() >>> - gpu tlb flush >>> >>> I have irqsoff trace reports for all of these if anyone is interested. >>> >>> Looks like lockdep would need to be off as well because I saw but >>> failed to capture a save_trace() in the 300us range. >>> >>> I think this is just the tip of the iceberg for irqsoff. >> >> I agree. >> >>> I'm not saying these don't need fixing as well, but there's no way >>> irq probe will ever be reliable with this approach. >> >> irq probe is a known to be unreliable heuristic endavour anyway and it >> cannot ever become truly reliable, except you put a gazillion of >> restrictions to the system state on it. > > Yep, totally agree. As you note below, this functionality is completely > disabled on every known distro kernel. > > >>> Going back to the RFC idea of pinning the irq affinity to the cpu >>> actually doing the probing (which is in a known context), what about >>> that is broken on UP? Just the implementation or is it the fundamental >>> concept? >> >> First of all, there is no guarantee that you can affine these >> interrupts at all. We have interrupt controllers which cannot set the >> affinity and they deliver to cpus in a round robin scheme or whatever >> hardware designers thought would be clever. >> >> Second, what prevents the following scenario on UP or the affine core: >> >> probe_start() >> interrupt >> looong running handler (usb is an obvious candidate) >> printk() >> >> That will swallow your uart state and ruin detection as well. Yes, the RFC idea was just for reducing the risk of failure, not perfect. I know it depends on the interrupt controllers, but I didn't know the error occurred after others set affinity. I understand there is no guarantee at all in my RFC case. > Yeah, ok, so fundamentally broken concept to pin the irqs for probing. > Thanks for clarifying that. > > >> So for the problem at hand, we really need to prevent that something >> is fiddling with the uart in the first place and the most obvious way >> is to serialize against printk. > > I'm ok with just the original patch 1 (which I reviewed some time ago). > > >> We can debate whether the autoprobe code is the right place or not, we >> can actually stick it into the 8250 driver and be done with it >> because: >> >> If you look at the actual autoprobe users aside of 8250. That's really >> all ancient ISA hardware and hardly interesting. So all we really care >> about are the 8250 serial ports. In this case, I think [patch v2 1/3] is enough. console_lock is required in autoconfig_irq() to resolve other race conditions before calling probe_irq_on(). >> >> Now lets look at the 8250 serial ports. I just checked the random >> collection of machines I have access to: >> >> In 100% of all cases ttyS0 is on irq4 and ttyS1 is on irq3 >> >> All of the machines have even a correct PNP entry of the irq resource >> for the serial ports. And there is pretty old crap in that lot. >> >> So the real question is: Why would we autoprobe in the first place? >> >> Debian, Fedora, OpenSuse, SLES have: >> >> # CONFIG_SERIAL_8250_DETECT_IRQ is not set >> >> and so do my kernels. >> I just built one with that option enabled for the fun of it and it >> still uses the PNP information. No autoprobing. >> >> So why are you interested in that serial irq autoprobe crap at all? > Because RHEL6 uses CONFIG_SERIAL_8250_DETECT_IRQ=y unfortunately. > Agree, but I guess the hardware in question is non-PNP serial-over-LAN. > It's Taichi's hardware so he can be more specific. Also, this problem > would not apply to 8250 ports @ the ISA addresses (3f8,irq 4 & 2f8,irq 3) > because those are predefined on the platform. > > Taichi's original proposal was to add module parameters for the serial > driver, which I am dead set against, having just struggled to deal with > ancient module parameters while splitting the 8250 driver. As you guys mentioned, irq3 and 4 for console ports are predefined basically. That's why I introduced original patch to skip autoconfig_irq only for console although the parameter thing was not good idea. I'm using one of very large HP platform. It expects ISA addresses for SOL, but doesn't provides PNP define like PNP0501. So autoconfig_irq() can overwrites valid irq with invalid one... > I also noted in reviewing that proposal that user-space tools (setserial) > can reset the irq to a known value after driver load. Ubuntu, for one, > runs setserial as part of boot (to restore serial hardware to known-working > configuration). I already got the following console solutions after discussion with Peter. - Force set irq before any APs and getty open /dev/console. Users have to know valid irq#. - Fix FW to define PNP - CONFIG_SERIAL_8250_DETECT_IRQ=n Thanks, Taichi {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I