All of lore.kernel.org
 help / color / mirror / Atom feed
From: Robert Baldyga <r.baldyga@samsung.com>
To: Krzysztof Kozlowski <k.kozlowski@samsung.com>
Cc: gregkh@linuxfoundation.org, akpm@linux-foundation.org,
	jslaby@suse.cz, linux-serial@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Marek Szyprowski <m.szyprowski@samsung.com>
Subject: Re: [PATCH 0/2] serial: samsung: fix DMA for small FIFO sizes
Date: Fri, 31 Jul 2015 10:17:13 +0200	[thread overview]
Message-ID: <55BB2F09.8000501@samsung.com> (raw)
In-Reply-To: <CAJKOXPfwnYVyJCPPyG5L0B2kw9nG1KNgj7L6Sy2hJEbihf-b2Q@mail.gmail.com>

On 07/31/2015 10:04 AM, Krzysztof Kozlowski wrote:
> 2015-07-30 18:14 GMT+09:00 Robert Baldyga <r.baldyga@samsung.com>:
>> Hello,
>>
>> This patch set fixes bug causing serial hang in DMA mode for FIFO sizes
>> smaller than cache alignment. The first patch fixes DMA mode entering
>> condition to avoid starting with buffer smaller than cache line size.
>> Second patch fixes the serial hang bug, which was caused by unproper
>> buffer aligning algorithm which assumed that there is always enough
>> free space in FIFO for excessive bytes of buffer that is being alligned.
>>
>> Best regards,
>> Robert Baldyga
>>
>> Marek Szyprowski (1):
>>   serial: samsung: calculate min_dma_size
>>
>> Robert Baldyga (1):
>>   serial: samsung: fix DMA for FIFO smaller than cache line size
>>
>>  drivers/tty/serial/samsung.c | 47 +++++++++++++++++++++++++++++---------------
>>  drivers/tty/serial/samsung.h |  1 +
>>  2 files changed, 32 insertions(+), 16 deletions(-)
> 
> Does this apply for stable backporting? Or at least fixes tag
> indicating a bug? I could not figure this out from description of
> first patch. For second patch it seems it applies.

These patches are two steps of fixing the bug, so they both apply for
stable backporting.

> 
> Anyway I would appreciate a reported-by credits.

Sure ;)

Thanks,
Robert

      reply	other threads:[~2015-07-31  8:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-30  9:14 [PATCH 0/2] serial: samsung: fix DMA for small FIFO sizes Robert Baldyga
2015-07-30  9:14 ` [PATCH 1/2] serial: samsung: calculate min_dma_size Robert Baldyga
2015-07-30  9:14 ` [PATCH 2/2] serial: samsung: fix DMA for FIFO smaller than cache line size Robert Baldyga
2015-07-31  8:04 ` [PATCH 0/2] serial: samsung: fix DMA for small FIFO sizes Krzysztof Kozlowski
2015-07-31  8:17   ` Robert Baldyga [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BB2F09.8000501@samsung.com \
    --to=r.baldyga@samsung.com \
    --cc=akpm@linux-foundation.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jslaby@suse.cz \
    --cc=k.kozlowski@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.