From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Date: Fri, 31 Jul 2015 09:58:53 +0000 Subject: Re: [patch] drm/omap: checking for NULL instead of IS_ERR() Message-Id: <55BB440D.8060603@codeaurora.org> List-Id: References: <20150731093330.GA11127@mwanda> In-Reply-To: <20150731093330.GA11127@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter , David Airlie Cc: Daniel Vetter , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Fabian Frederick , Tomi Valkeinen , Laurent Pinchart , Thierry Reding Hi, On 07/31/2015 03:03 PM, Dan Carpenter wrote: > We recently start using the new drm_fb_helper functions but the error > handling needs to be updated as well to check for IS_ERR() instead of > NULL. > > Fixes: 377eb331375f ('drm/omap: Use new drm_fb_helper functions') > Signed-off-by: Dan Carpenter > > diff --git a/drivers/gpu/drm/omapdrm/omap_fbdev.c b/drivers/gpu/drm/omapdrm/omap_fbdev.c > index 08ef090..b8e4cde 100644 > --- a/drivers/gpu/drm/omapdrm/omap_fbdev.c > +++ b/drivers/gpu/drm/omapdrm/omap_fbdev.c > @@ -180,9 +180,9 @@ static int omap_fbdev_create(struct drm_fb_helper *helper, > mutex_lock(&dev->struct_mutex); > > fbi = drm_fb_helper_alloc_fbi(helper); > - if (!fbi) { > + if (IS_ERR(fbi)) { > dev_err(dev->dev, "failed to allocate fb info\n"); > - ret = -ENOMEM; > + ret = PTR_ERR(fbi); > goto fail_unlock; > } I was going to post out a v3 for this set. I'll squash this and mention the fix in the changelog. Thanks, Archit > > -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project From mboxrd@z Thu Jan 1 00:00:00 1970 From: Archit Taneja Subject: Re: [patch] drm/omap: checking for NULL instead of IS_ERR() Date: Fri, 31 Jul 2015 15:16:53 +0530 Message-ID: <55BB440D.8060603@codeaurora.org> References: <20150731093330.GA11127@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from smtp.codeaurora.org (smtp.codeaurora.org [198.145.29.96]) by gabe.freedesktop.org (Postfix) with ESMTPS id D7CBD6E313 for ; Fri, 31 Jul 2015 02:47:00 -0700 (PDT) In-Reply-To: <20150731093330.GA11127@mwanda> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Dan Carpenter , David Airlie Cc: Daniel Vetter , kernel-janitors@vger.kernel.org, dri-devel@lists.freedesktop.org, Fabian Frederick , Tomi Valkeinen , Laurent Pinchart , Thierry Reding List-Id: dri-devel@lists.freedesktop.org SGksCgpPbiAwNy8zMS8yMDE1IDAzOjAzIFBNLCBEYW4gQ2FycGVudGVyIHdyb3RlOgo+IFdlIHJl Y2VudGx5IHN0YXJ0IHVzaW5nIHRoZSBuZXcgZHJtX2ZiX2hlbHBlciBmdW5jdGlvbnMgYnV0IHRo ZSBlcnJvcgo+IGhhbmRsaW5nIG5lZWRzIHRvIGJlIHVwZGF0ZWQgYXMgd2VsbCB0byBjaGVjayBm b3IgSVNfRVJSKCkgaW5zdGVhZCBvZgo+IE5VTEwuCj4KPiBGaXhlczogMzc3ZWIzMzEzNzVmICgn ZHJtL29tYXA6IFVzZSBuZXcgZHJtX2ZiX2hlbHBlciBmdW5jdGlvbnMnKQo+IFNpZ25lZC1vZmYt Ynk6IERhbiBDYXJwZW50ZXIgPGRhbi5jYXJwZW50ZXJAb3JhY2xlLmNvbT4KPgo+IGRpZmYgLS1n aXQgYS9kcml2ZXJzL2dwdS9kcm0vb21hcGRybS9vbWFwX2ZiZGV2LmMgYi9kcml2ZXJzL2dwdS9k cm0vb21hcGRybS9vbWFwX2ZiZGV2LmMKPiBpbmRleCAwOGVmMDkwLi5iOGU0Y2RlIDEwMDY0NAo+ IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZmJkZXYuYwo+ICsrKyBiL2RyaXZl cnMvZ3B1L2RybS9vbWFwZHJtL29tYXBfZmJkZXYuYwo+IEBAIC0xODAsOSArMTgwLDkgQEAgc3Rh dGljIGludCBvbWFwX2ZiZGV2X2NyZWF0ZShzdHJ1Y3QgZHJtX2ZiX2hlbHBlciAqaGVscGVyLAo+ ICAgCW11dGV4X2xvY2soJmRldi0+c3RydWN0X211dGV4KTsKPgo+ICAgCWZiaSA9IGRybV9mYl9o ZWxwZXJfYWxsb2NfZmJpKGhlbHBlcik7Cj4gLQlpZiAoIWZiaSkgewo+ICsJaWYgKElTX0VSUihm YmkpKSB7Cj4gICAJCWRldl9lcnIoZGV2LT5kZXYsICJmYWlsZWQgdG8gYWxsb2NhdGUgZmIgaW5m b1xuIik7Cj4gLQkJcmV0ID0gLUVOT01FTTsKPiArCQlyZXQgPSBQVFJfRVJSKGZiaSk7Cj4gICAJ CWdvdG8gZmFpbF91bmxvY2s7Cj4gICAJfQoKSSB3YXMgZ29pbmcgdG8gcG9zdCBvdXQgYSB2MyBm b3IgdGhpcyBzZXQuIEknbGwgc3F1YXNoIHRoaXMgYW5kIG1lbnRpb24KdGhlIGZpeCBpbiB0aGUg Y2hhbmdlbG9nLgoKVGhhbmtzLApBcmNoaXQKCj4KPgoKLS0gClF1YWxjb21tIElubm92YXRpb24g Q2VudGVyLCBJbmMuIGlzIGEgbWVtYmVyIG9mIENvZGUgQXVyb3JhIEZvcnVtLAphIExpbnV4IEZv dW5kYXRpb24gQ29sbGFib3JhdGl2ZSBQcm9qZWN0Cl9fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxp c3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vZHJpLWRldmVsCg==