From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Fri, 31 Jul 2015 11:51:52 +0200 Subject: [PATCH 0/7] Another posting of the Dove PMU series In-Reply-To: <20150725201723.GD604@lunn.ch> References: <20150715185859.GC7557@n2100.arm.linux.org.uk> <20150725201723.GD604@lunn.ch> Message-ID: <55BB4538.1090708@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Andrew, On 25/07/2015 22:17, Andrew Lunn wrote: > On Wed, Jul 15, 2015 at 07:58:59PM +0100, Russell King - ARM Linux wrote: >> What it says in the subject. Not hopeful of a successful outcome, so I'm >> not going to bother wasting time writing stuff here. > > Hi Gregory > > I took at look at Russell's patches. I rebased them onto -rc1. There > were a few minor merge problems, all easy to fix. I added > Signed-off-by: since i did make changes, but 99.9% of the credit for > these patches is definitely to Russell. > > The last patch, which is converting mach-dove to use the new PMU > driver however does not build. With mvebu_v7_defconfig i get: > > CC drivers/soc/dove/pmu.o > drivers/soc/dove/pmu.c: In function dove_init_pmu_legacy?: > drivers/soc/dove/pmu.c:400:46: error: IRQ_DOVE_PMU_START undeclared (first use in this function) > irq_domain_associate_many(pmu->irq_domain, IRQ_DOVE_PMU_START, > ^ > drivers/soc/dove/pmu.c:400:46: note: each undeclared identifier is reported only once for each function it appears in > > and dove_defconfig: > > CC arch/arm/mach-dove/common.o > arch/arm/mach-dove/common.c:381:15: error: PWR_VPU_PWR_DWN_MASK undeclared here (not in a function) > .pwr_mask = PMU_PWR_VPU_PWR_DWN_MASK, > ^ > arch/arm/mach-dove/common.c:382:15: error: PMU_SW_RST_VIDEO_MASK undeclared here (not in a function) > .rst_mask = PMU_SW_RST_VIDEO_MASK, > ^ > arch/arm/mach-dove/common.c:383:15: error: PMU_ISO_VIDEO_MASK undeclared here (not in a function) > .iso_mask = PMU_ISO_VIDEO_MASK, > ^ > arch/arm/mach-dove/common.c:386:15: error: PMU_PWR_GPU_PWR_DWN_MASK undeclared here (not in a function) > .pwr_mask = PMU_PWR_GPU_PWR_DWN_MASK, > ^ > arch/arm/mach-dove/common.c:387:15: error: PMU_SW_RST_GPU_MASK undeclared here (not in a function) > .rst_mask = PMU_SW_RST_GPU_MASK, > ^ > arch/arm/mach-dove/common.c:388:15: error: PMU_ISO_GPU_MASK undeclared here (not in a function) > .iso_mask = PMU_ISO_GPU_MASK, > > So i've dropped the last patch. > > I boot tested mvebu_v7_defconfig with these patches, and ran the > rtctest, which shows the RTC interrupt it working. The vpu and gpu > power domains are in /sys, but i don't have anything connected to the > HDMI port in order to test them. > > You can find the patches here: > > https://github.com/lunn/linux.git v4.2-rc1-dove-pmu I have merged your branch in mvebu/for-next and if there is no complain then it will be part of the next pull request. Thanks, Gregory -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH 0/7] Another posting of the Dove PMU series Date: Fri, 31 Jul 2015 11:51:52 +0200 Message-ID: <55BB4538.1090708@free-electrons.com> References: <20150715185859.GC7557@n2100.arm.linux.org.uk> <20150725201723.GD604@lunn.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <20150725201723.GD604-g2DYL2Zd6BY@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Andrew Lunn Cc: Russell King , linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ian Campbell , Jason Cooper , Kumar Gala , Mark Rutland , Pawel Moll , Rob Herring , Sebastian Hesselbarth List-Id: devicetree@vger.kernel.org Hi Andrew, On 25/07/2015 22:17, Andrew Lunn wrote: > On Wed, Jul 15, 2015 at 07:58:59PM +0100, Russell King - ARM Linux wr= ote: >> What it says in the subject. Not hopeful of a successful outcome, s= o I'm >> not going to bother wasting time writing stuff here. >=20 > Hi Gregory >=20 > I took at look at Russell's patches. I rebased them onto -rc1. There > were a few minor merge problems, all easy to fix. I added > Signed-off-by: since i did make changes, but 99.9% of the credit for > these patches is definitely to Russell. >=20 > The last patch, which is converting mach-dove to use the new PMU > driver however does not build. With mvebu_v7_defconfig i get: >=20 > CC drivers/soc/dove/pmu.o > drivers/soc/dove/pmu.c: In function dove_init_pmu_legacy=E2: > drivers/soc/dove/pmu.c:400:46: error: IRQ_DOVE_PMU_START undeclared (= first use in this function) > irq_domain_associate_many(pmu->irq_domain, IRQ_DOVE_PMU_START, > ^ > drivers/soc/dove/pmu.c:400:46: note: each undeclared identifier is re= ported only once for each function it appears in >=20 > and dove_defconfig: >=20 > CC arch/arm/mach-dove/common.o > arch/arm/mach-dove/common.c:381:15: error: PWR_VPU_PWR_DWN_MASK undec= lared here (not in a function) > .pwr_mask =3D PMU_PWR_VPU_PWR_DWN_MASK, > ^ > arch/arm/mach-dove/common.c:382:15: error: PMU_SW_RST_VIDEO_MASK unde= clared here (not in a function) > .rst_mask =3D PMU_SW_RST_VIDEO_MASK, > ^ > arch/arm/mach-dove/common.c:383:15: error: PMU_ISO_VIDEO_MASK undecla= red here (not in a function) > .iso_mask =3D PMU_ISO_VIDEO_MASK, > ^ > arch/arm/mach-dove/common.c:386:15: error: PMU_PWR_GPU_PWR_DWN_MASK u= ndeclared here (not in a function) > .pwr_mask =3D PMU_PWR_GPU_PWR_DWN_MASK, > ^ > arch/arm/mach-dove/common.c:387:15: error: PMU_SW_RST_GPU_MASK undecl= ared here (not in a function) > .rst_mask =3D PMU_SW_RST_GPU_MASK, > ^ > arch/arm/mach-dove/common.c:388:15: error: PMU_ISO_GPU_MASK undeclare= d here (not in a function) > .iso_mask =3D PMU_ISO_GPU_MASK, >=20 > So i've dropped the last patch. >=20 > I boot tested mvebu_v7_defconfig with these patches, and ran the > rtctest, which shows the RTC interrupt it working. The vpu and gpu > power domains are in /sys, but i don't have anything connected to the > HDMI port in order to test them. >=20 > You can find the patches here: >=20 > https://github.com/lunn/linux.git v4.2-rc1-dove-pmu I have merged your branch in mvebu/for-next and if there is no complain= then it will be part of the next pull request. Thanks, Gregory --=20 Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com -- To unsubscribe from this list: send the line "unsubscribe devicetree" i= n the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html