From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-4.6 7/8] libxl/save&restore&convert:
 Switch to new EMULATOR_XENSTORE_DATA records
Date: Fri, 31 Jul 2015 11:17:26 +0100
Message-ID: <55BB4B36.90609@citrix.com>
References: <1438119883-8083-1-git-send-email-andrew.cooper3@citrix.com>
	<1438119883-8083-8-git-send-email-andrew.cooper3@citrix.com>
	<21944.49224.377201.209605@mariner.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <21944.49224.377201.209605@mariner.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Campbell <Ian.Campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 29/07/15 13:00, Ian Jackson wrote:
>
>> +        rc = libxl__restore_emulator_xenstore_data(
> ( in wrong place.
>
> But apart from that it looks fine.

I am sorry, but this request is unreasonable IMO.

This is a function call, not an integer assignment.  Moving the bracket
onto the next line is counterintuitive, and I cannot find a single style
anywhere which suggests it being a rational thing to do.

~Andrew