From mboxrd@z Thu Jan 1 00:00:00 1970 Message-ID: <55BB7CA4.1020300@ti.com> Date: Fri, 31 Jul 2015 19:18:20 +0530 From: Sekhar Nori MIME-Version: 1.0 To: Vignesh R , Mark Brown , David Woodhouse , Brian Norris , Tony Lindgren , Russell King CC: Huang Shijie , , , , , , Subject: Re: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi References: <1438072876-16338-1-git-send-email-vigneshr@ti.com> <1438072876-16338-5-git-send-email-vigneshr@ti.com> In-Reply-To: <1438072876-16338-5-git-send-email-vigneshr@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tuesday 28 July 2015 02:11 PM, Vignesh R wrote: > Add qspi memory mapped region entries for DRA7xx based SoCs. > > Signed-off-by: Vignesh R > --- > arch/arm/boot/dts/am4372.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index ade28c790f4b..5317a0f24ab9 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi The patch talks about DRA7x in subject and description but you modify AM437x here. You have got commit text mixed up between 4/5 and 5/5. Probably not the kind of feedback you are looking for an RFC, but since I noticed it.. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sekhar Nori Subject: Re: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi Date: Fri, 31 Jul 2015 19:18:20 +0530 Message-ID: <55BB7CA4.1020300@ti.com> References: <1438072876-16338-1-git-send-email-vigneshr@ti.com> <1438072876-16338-5-git-send-email-vigneshr@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1438072876-16338-5-git-send-email-vigneshr@ti.com> Sender: linux-kernel-owner@vger.kernel.org To: Vignesh R , Mark Brown , David Woodhouse , Brian Norris , Tony Lindgren , Russell King Cc: Huang Shijie , linux-omap@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, linux-spi@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Tuesday 28 July 2015 02:11 PM, Vignesh R wrote: > Add qspi memory mapped region entries for DRA7xx based SoCs. > > Signed-off-by: Vignesh R > --- > arch/arm/boot/dts/am4372.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index ade28c790f4b..5317a0f24ab9 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi The patch talks about DRA7x in subject and description but you modify AM437x here. You have got commit text mixed up between 4/5 and 5/5. Probably not the kind of feedback you are looking for an RFC, but since I noticed it.. Thanks, Sekhar From mboxrd@z Thu Jan 1 00:00:00 1970 From: nsekhar@ti.com (Sekhar Nori) Date: Fri, 31 Jul 2015 19:18:20 +0530 Subject: [RFC PATCH 4/5] ARM: dts: DRA7: Add memory map region entries for qspi In-Reply-To: <1438072876-16338-5-git-send-email-vigneshr@ti.com> References: <1438072876-16338-1-git-send-email-vigneshr@ti.com> <1438072876-16338-5-git-send-email-vigneshr@ti.com> Message-ID: <55BB7CA4.1020300@ti.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tuesday 28 July 2015 02:11 PM, Vignesh R wrote: > Add qspi memory mapped region entries for DRA7xx based SoCs. > > Signed-off-by: Vignesh R > --- > arch/arm/boot/dts/am4372.dtsi | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi > index ade28c790f4b..5317a0f24ab9 100644 > --- a/arch/arm/boot/dts/am4372.dtsi > +++ b/arch/arm/boot/dts/am4372.dtsi The patch talks about DRA7x in subject and description but you modify AM437x here. You have got commit text mixed up between 4/5 and 5/5. Probably not the kind of feedback you are looking for an RFC, but since I noticed it.. Thanks, Sekhar