All of lore.kernel.org
 help / color / mirror / Atom feed
From: mishal@softerra.com (mishal)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4] ARM: dts: add bcm2835-pwm bindings
Date: Fri, 31 Jul 2015 18:12:42 +0300	[thread overview]
Message-ID: <55BB906A.9000105@softerra.com> (raw)
In-Reply-To: <20150225145017.GB5132@x1>

Tried with latest rpi kernel from github, branch rpi-4.0.y on RaspberryPi A+
on pins 18 and 19
     pwm_pins: pwm {
         brcm,pins = <18 19>;
         brcm,function = <2 2>; /* alt5*/
     };

and pins 12, 13

     pwm_pins: pwm {
         brcm,pins = <12 13>;
         brcm,function = <4 4>; /* alt0*/
     };

different combinations for period/duty_cycle without any output.

(WiringPi library works on pins 18 and 12.)
Did something changed in recent kernels?
Thank you.


On 25.02.15 16:50, Lee Jones wrote:
> On Thu, 15 Jan 2015, Bart Tanghe wrote:
>
>> To probe the bcm2835-pwm driver properly, this dts bindings has to be added
>> to the bcm2835 dtsi file.
>> In expectation of a bcm2835 clock driver, I've added fixed-clock clock binding.
>> ---
>> Changes in v4:
>>   - node added by reg value
>>
>> Signed-off-by: Bart Tanghe <bart.tanghe@thomasmore.be>
>> Acked-by: Stephen Warren <swarren@wwwdotorg.org>
> Applied, thanks.
>
>> diff --git a/arch/arm/boot/dts/bcm2835.dtsi b/arch/arm/boot/dts/bcm2835.dtsi
>> index 3342cb1..e8a0f13 100644
>> --- a/arch/arm/boot/dts/bcm2835.dtsi
>> +++ b/arch/arm/boot/dts/bcm2835.dtsi
>> @@ -122,6 +123,14 @@
>>   			status = "disabled";
>>   		};
>>   
>> +                pwm: pwm at 7e20c000 {
>> +                        compatible = "brcm,bcm2835-pwm";
>> +                        reg = <0x7e20c000 0x28>;
>> +                        clocks = <&clk_pwm>;
>> +                        #pwm-cells = <2>;
>> +                        status = "disabled";
>> +                };
>> +
>>   		sdhci: sdhci at 7e300000 {
>>   			compatible = "brcm,bcm2835-sdhci";
>>   			reg = <0x7e300000 0x100>;
>> @@ -179,5 +188,13 @@
>>   			clock-output-names = "spi";
>>   			clock-frequency = <250000000>;
>>   		};
>> +
>> +		clk_pwm: clock at 3 {
>> +			compatible = "fixed-clock";
>> +			reg = <3>;
>> +			#clock-cells = <0>;
>> +			clock-output-names = "pwm";
>> +			clock-frequency = <9200000>;
>> +		};
>>   	};
>>   };

      reply	other threads:[~2015-07-31 15:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-15 12:33 [PATCH v4] ARM: dts: add bcm2835-pwm bindings Bart Tanghe
2015-01-15 12:33 ` Bart Tanghe
2015-01-15 12:33 ` Bart Tanghe
2015-02-25 14:50 ` Lee Jones
2015-02-25 14:50   ` Lee Jones
2015-02-25 14:50   ` Lee Jones
2015-07-31 15:12   ` mishal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BB906A.9000105@softerra.com \
    --to=mishal@softerra.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.