From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bryan O'Donoghue Subject: Re: [PATCH] drm/nouveau/gem: tolerate a buffer specified multiple times Date: Fri, 31 Jul 2015 17:43:35 +0100 Message-ID: <55BBA5B7.9040809@nexus-software.ie> References: <1438252085-4773-1-git-send-email-pure.logic@nexus-software.ie> <55BA3966.1050806@hurleysoftware.com> <55BA3A12.4000800@nexus-software.ie> <55BA3B21.8000603@nexus-software.ie> <55BA9AF6.6060808@hurleysoftware.com> <55BABB59.9080409@nexus-software.ie> <55BB457F.2060903@nexus-software.ie> <55BB46D4.9010006@nexus-software.ie> <55BB4D82.8070605@nexus-software.ie> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mail-wi0-f175.google.com (mail-wi0-f175.google.com [209.85.212.175]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D2C06EDB2 for ; Fri, 31 Jul 2015 09:43:39 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so41507065wib.0 for ; Fri, 31 Jul 2015 09:43:36 -0700 (PDT) In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ilia Mirkin Cc: Peter Hurley , Timo Aaltonen , Emil Velikov , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Ben Skeggs , Maarten Lankhorst List-Id: dri-devel@lists.freedesktop.org T24gMzEvMDcvMTUgMTc6MzYsIElsaWEgTWlya2luIHdyb3RlOgo+IE9uIEZyaSwgSnVsIDMxLCAy MDE1IGF0IDY6MjcgQU0sIEJyeWFuIE8nRG9ub2dodWUKPiA8cHVyZS5sb2dpY0BuZXh1cy1zb2Z0 d2FyZS5pZT4gd3JvdGU6Cj4+IGFoIG5vLi4uIDIuNC42MCBpcyByaWdodC4uLgo+Pgo+PiBZZXMg c28gSWxpYSAtIEkndmUgc3dpdGNoZWQgb3V0IDIuNC42MCBhcyBwZXIgeW91ciBzdWdnZXN0aW9u IHRvIDIuNC41Ngo+PiAoZ2V0dGluZyB0aGUgdmVyc2lvbiBudW1iZXJzIHJpZ2h0IDopICkgYW5k IGl0J3Mgc3RpbGwgZGVmaW5pdGVseSBnaXZpbmcgbWUKPj4gdGhlIG11bHRpcGxlIGluc3RhbmNl cyBtZXNzYWdlLgo+Cj4gVGhpcyBpcyBnb2luZyB0byBzb3VuZCBsaWtlIGEgc3R1cGlkIHF1ZXN0 aW9uLCBidXQgSSdsbCBhc2sgYW55d2F5cyAtLQo+IHlvdSAqZGlkKiByZXN0YXJ0IGNocm9tZSBh ZnRlciBjaGFuZ2luZyBsaWJkcm0gdmVyc2lvbnMsIHJpZ2h0PwoKVGhlcmUgYXJlIG5vIHN0dXBp ZCBxdWVzdGlvbnMgLSBqdXN0IHN0dXBpZCBhbnN3ZXJzIGxpa2UgJ3doYWRkeWEgbWVhbiAKcmVz dGFydCBjaHJvbWUnCgpTZXJpb3VzbHkgdGhvdWdoLCBJJ3ZlIHJlc3RhcnRlZCB0aGUgbWFjaGlu ZSBlYWNoIHRpbWUgSSd2ZSB0cmllZCB0byAKc3dpdGNoIG91dCB0aG9zZSBsaWJyYXJpZXMsIHNv IGl0J3MgZGVmaW5pdGVseSBub3QgdGhhdC4KCj4gSSB3YXMgZ29pbmcgdG8gbWVudGlvbiB0aGF0 IHRoZXJlIHdlcmUgYSBoYW5kZnVsIG9mIGZpeGVzIGluIGxpYmRybSwKPiBwb3RlbnRpYWxseSBz aW5jZSAyLjQuNTYgKEkgZm9yZ2V0IHRoZSBleGFjdCB2ZXJzaW9ucyksIGJ1dCBpZiAyLjQuNjAK PiBhbHNvIGZhaWxzLCB0aGVuIHRoYXQgd291bGQgaGF2ZSB0aGVtLgo+Cj4gVGhlcmUgd2FzIGEg ZmluYWwgYXNzZXJ0KCkgYWRkZWQgaW4gMi40LjYyLCBidXQgdGhhdCB3YXMgdG8gYmV0dGVyCj4g aXNvbGF0ZSB0aGUgY2F1c2Ugb2Ygd2VpcmRvIGNyYXNoZXMgKGkuZS4gY3Jhc2ggd2hlbiB0aGUg dGhpbmcgZ29pbmcKPiB3cm9uZyBoYXBwZW5zIHJhdGhlciB0aGFuIHN0YXNoaW5nIGJhZCBwb2lu dGVycyBmb3IgbGF0ZXIgdmVyeQo+IGNvbmZ1c2luZyBkZXJlZmVyZW5jZSkuIE5vdCBHUFUgY3Jh c2hlcy4KPgo+IEp1c3QgZm9yIHlvdXIgaW5mb3JtYXRpb24sCj4KPiBub3V2ZWF1IEVbICAgUEZJ Rk9dWzAwMDA6MDE6MDAuMF0gUEZJRk86IHJlYWQgZmF1bHQgYXQKPiAweDAwMDNlMjEwMDAgW1BB R0VfTk9UX1BSRVNFTlRdIGZyb20gKHVua25vd24gZW51bQo+IDB4MDAwMDAwMDApL0dQQzAvKHVu a25vd24gZW51bSAweDAwMDAwMDBmKSBvbiBjaGFubmVsIDB4MDA3ZjgwYzAwMAo+IFt1bmtub3du XQo+Cj4gbWVhbnMgdGhhdCB0aGVyZSB3YXMgVk0gZmF1bHQgZnJvbSBhbiB1bmtub3duIGdwdSB1 bml0ICg/Pz8pIHdoZW4KPiByZWFkaW5nIHNvbWUgcmVzb3VyY2UgYnkgdGhlIEdQVS4KCk9LLCBJ IHdhcyBhc3N1bWluZyBpdCB3YXMgYSBzaWRlIGVmZmVjdCBvZiB0aGUgLUVJTlZBTCB3aGVuIHdl IGdldCB0aGUgCm11bHRpcGxlIGluc3RhbmNlcyBtZXNzYWdlLgoKPiAoVGhlIEdQVSBoYXMgaXRz IG93biBNTVUuKQo+IFVuZm9ydHVuYXRlbHkgdGhpcyBjYW4gaGFwcGVuIGZvciBvbmUgb2YgYSBt aWxsaW9uIHJlYXNvbnMsIHRoZQo+IGJpZ2dlc3Qgb25lIGJlaW5nICJ1bmtub3duIiwgYnV0IG1l c2EgZGVmaW5pdGVseSBkb2Vzbid0IGhhbmRsZQo+IGNvbW1hbmQgc3VibWlzc2lvbiBmYWlsdXJl cyBwYXJ0aWN1bGFybHkgd2VsbC4uLiBzaG91bGQgcHJvYmFibHkgYWRkIGEKPiAiZmFpbCAxJSBv ZiB0aGUgdGltZSIgdGhpbmcgdG8gaGVscCBmaXggdGhhdCB1cC4KPgo+IERvIHlvdSBoYXZlIGEg cmVwcm9kdWNpYmxlIHdheSBvZiBhY2hpZXZpbmcgdGhlIG11bHRpcGxlIGJ1ZmZlciBvbgo+IHZh bGlkYXRpb24gbGlzdCB0aGluZz8gV2hhdCBHUFUgZG8geW91IGhhdmU/IChMb29raW5nIGZvciBh IGNvZGVuYW1lLAo+IG5vdCBhIG1hcmtldGluZyBuYW1lLi4uIGxzcGNpIHNob3VsZCBoYXZlIGl0 Li4uIEdGeHh4IG9yIEdLeHh4IG9yCgowMTowMC4wIFZHQSBjb21wYXRpYmxlIGNvbnRyb2xsZXI6 IE5WSURJQSBDb3Jwb3JhdGlvbiBHSzEwN00gW0dlRm9yY2UgR1QgCjc1ME0gTWFjIEVkaXRpb25d IChyZXYgYTEpIChwcm9nLWlmIDAwIFtWR0EgY29udHJvbGxlcl0pCglTdWJzeXN0ZW06IEFwcGxl IEluYy4gRGV2aWNlIDAxMzAKCUZsYWdzOiBidXMgbWFzdGVyLCBmYXN0IGRldnNlbCwgbGF0ZW5j eSAwLCBJUlEgNDUKCU1lbW9yeSBhdCBjMDAwMDAwMCAoMzItYml0LCBub24tcHJlZmV0Y2hhYmxl KSBbc2l6ZT0xNk1dCglNZW1vcnkgYXQgODAwMDAwMDAgKDY0LWJpdCwgcHJlZmV0Y2hhYmxlKSBb c2l6ZT0yNTZNXQoJTWVtb3J5IGF0IDkwMDAwMDAwICg2NC1iaXQsIHByZWZldGNoYWJsZSkgW3Np emU9MzJNXQoJSS9PIHBvcnRzIGF0IDEwMDAgW3NpemU9MTI4XQoJRXhwYW5zaW9uIFJPTSBhdCBj MTAwMDAwMCBbZGlzYWJsZWRdIFtzaXplPTUxMktdCglDYXBhYmlsaXRpZXM6IFs2MF0gUG93ZXIg TWFuYWdlbWVudCB2ZXJzaW9uIDMKCUNhcGFiaWxpdGllczogWzY4XSBNU0k6IEVuYWJsZSsgQ291 bnQ9MS8xIE1hc2thYmxlLSA2NGJpdCsKCUNhcGFiaWxpdGllczogWzc4XSBFeHByZXNzIEVuZHBv aW50LCBNU0kgMDAKCUNhcGFiaWxpdGllczogW2I0XSBWZW5kb3IgU3BlY2lmaWMgSW5mb3JtYXRp b246IExlbj0xNCA8Pz4KCUNhcGFiaWxpdGllczogWzEwMF0gVmlydHVhbCBDaGFubmVsCglDYXBh YmlsaXRpZXM6IFsxMjhdIFBvd2VyIEJ1ZGdldGluZyA8Pz4KCUNhcGFiaWxpdGllczogWzQyMF0g QWR2YW5jZWQgRXJyb3IgUmVwb3J0aW5nCglDYXBhYmlsaXRpZXM6IFs2MDBdIFZlbmRvciBTcGVj aWZpYyBJbmZvcm1hdGlvbjogSUQ9MDAwMSBSZXY9MSBMZW49MDI0IDw/PgoJQ2FwYWJpbGl0aWVz OiBbOTAwXSAjMTkKCUtlcm5lbCBkcml2ZXIgaW4gdXNlOiBub3V2ZWF1CgpNYWNib29rIHBybyBy ZXRpbmEgMjAxNApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f XwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVza3RvcC5vcmcK aHR0cDovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZlbAo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753034AbbGaQnj (ORCPT ); Fri, 31 Jul 2015 12:43:39 -0400 Received: from mail-wi0-f173.google.com ([209.85.212.173]:35878 "EHLO mail-wi0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751096AbbGaQni (ORCPT ); Fri, 31 Jul 2015 12:43:38 -0400 Message-ID: <55BBA5B7.9040809@nexus-software.ie> Date: Fri, 31 Jul 2015 17:43:35 +0100 From: "Bryan O'Donoghue" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Ilia Mirkin CC: Peter Hurley , Timo Aaltonen , Emil Velikov , Maarten Lankhorst , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Ben Skeggs Subject: Re: [PATCH] drm/nouveau/gem: tolerate a buffer specified multiple times References: <1438252085-4773-1-git-send-email-pure.logic@nexus-software.ie> <55BA3966.1050806@hurleysoftware.com> <55BA3A12.4000800@nexus-software.ie> <55BA3B21.8000603@nexus-software.ie> <55BA9AF6.6060808@hurleysoftware.com> <55BABB59.9080409@nexus-software.ie> <55BB457F.2060903@nexus-software.ie> <55BB46D4.9010006@nexus-software.ie> <55BB4D82.8070605@nexus-software.ie> In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 31/07/15 17:36, Ilia Mirkin wrote: > On Fri, Jul 31, 2015 at 6:27 AM, Bryan O'Donoghue > wrote: >> ah no... 2.4.60 is right... >> >> Yes so Ilia - I've switched out 2.4.60 as per your suggestion to 2.4.56 >> (getting the version numbers right :) ) and it's still definitely giving me >> the multiple instances message. > > This is going to sound like a stupid question, but I'll ask anyways -- > you *did* restart chrome after changing libdrm versions, right? There are no stupid questions - just stupid answers like 'whaddya mean restart chrome' Seriously though, I've restarted the machine each time I've tried to switch out those libraries, so it's definitely not that. > I was going to mention that there were a handful of fixes in libdrm, > potentially since 2.4.56 (I forget the exact versions), but if 2.4.60 > also fails, then that would have them. > > There was a final assert() added in 2.4.62, but that was to better > isolate the cause of weirdo crashes (i.e. crash when the thing going > wrong happens rather than stashing bad pointers for later very > confusing dereference). Not GPU crashes. > > Just for your information, > > nouveau E[ PFIFO][0000:01:00.0] PFIFO: read fault at > 0x0003e21000 [PAGE_NOT_PRESENT] from (unknown enum > 0x00000000)/GPC0/(unknown enum 0x0000000f) on channel 0x007f80c000 > [unknown] > > means that there was VM fault from an unknown gpu unit (???) when > reading some resource by the GPU. OK, I was assuming it was a side effect of the -EINVAL when we get the multiple instances message. > (The GPU has its own MMU.) > Unfortunately this can happen for one of a million reasons, the > biggest one being "unknown", but mesa definitely doesn't handle > command submission failures particularly well... should probably add a > "fail 1% of the time" thing to help fix that up. > > Do you have a reproducible way of achieving the multiple buffer on > validation list thing? What GPU do you have? (Looking for a codename, > not a marketing name... lspci should have it... GFxxx or GKxxx or 01:00.0 VGA compatible controller: NVIDIA Corporation GK107M [GeForce GT 750M Mac Edition] (rev a1) (prog-if 00 [VGA controller]) Subsystem: Apple Inc. Device 0130 Flags: bus master, fast devsel, latency 0, IRQ 45 Memory at c0000000 (32-bit, non-prefetchable) [size=16M] Memory at 80000000 (64-bit, prefetchable) [size=256M] Memory at 90000000 (64-bit, prefetchable) [size=32M] I/O ports at 1000 [size=128] Expansion ROM at c1000000 [disabled] [size=512K] Capabilities: [60] Power Management version 3 Capabilities: [68] MSI: Enable+ Count=1/1 Maskable- 64bit+ Capabilities: [78] Express Endpoint, MSI 00 Capabilities: [b4] Vendor Specific Information: Len=14 Capabilities: [100] Virtual Channel Capabilities: [128] Power Budgeting Capabilities: [420] Advanced Error Reporting Capabilities: [600] Vendor Specific Information: ID=0001 Rev=1 Len=024 Capabilities: [900] #19 Kernel driver in use: nouveau Macbook pro retina 2014