Re: [PATCH v2 08/12] IB/srp: Use pd->local_dma_lkey

[Bart Van Assche <bart.vanassche@sandisk.com>]

On 07/30/2015 04:22 PM, Jason Gunthorpe wrote:
> Replace all leys with  pd->local_dma_lkey. This driver does not support
> iWarp, so this is safe.
>
> The insecure use of ib_get_dma_mr is thus isolated to an rkey, and will
> have to be fixed separately.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
> Reviewed-by: Sagi Grimberg <sagig@mellanox.com>
> ---
>   drivers/infiniband/ulp/srp/ib_srp.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/srp/ib_srp.c b/drivers/infiniband/ulp/srp/ib_srp.c
> index 31a20b462266..19a1356f8b2a 100644
> --- a/drivers/infiniband/ulp/srp/ib_srp.c
> +++ b/drivers/infiniband/ulp/srp/ib_srp.c
> @@ -3146,7 +3146,7 @@ static ssize_t srp_create_target(struct device *dev,
>   	target->io_class	= SRP_REV16A_IB_IO_CLASS;
>   	target->scsi_host	= target_host;
>   	target->srp_host	= host;
> -	target->lkey		= host->srp_dev->mr->lkey;
> +	target->lkey		= host->srp_dev->pd->local_dma_lkey;
>   	target->rkey		= host->srp_dev->mr->rkey;
>   	target->cmd_sg_cnt	= cmd_sg_entries;
>   	target->sg_tablesize	= indirect_sg_entries ? : cmd_sg_entries;
>

Reviewed-by: Bart Van Assche <bart.vanassche@sandisk.com>