From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paolo Bonzini Subject: Re: [PATCH kvm-unit-tests] x86: fix last commit Date: Sun, 2 Aug 2015 09:47:02 +0200 Message-ID: <55BDCAF6.6080907@redhat.com> References: <1438263504-45362-1-git-send-email-pbonzini@redhat.com> <55BD30BC.2090201@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Cc: Shih-Wei Li , kvm@vger.kernel.org To: Bandan Das Return-path: Received: from mail-wi0-f182.google.com ([209.85.212.182]:37551 "EHLO mail-wi0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751665AbbHBHrI (ORCPT ); Sun, 2 Aug 2015 03:47:08 -0400 Received: by wibud3 with SMTP id ud3so77597181wib.0 for ; Sun, 02 Aug 2015 00:47:07 -0700 (PDT) In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 01/08/2015 23:20, Bandan Das wrote: >> > Actually it should be using the RTC alarm to wake itself up. But the >> > firmware changed recently and the ACPI PMBASE moved from 0xb000 to >> > 0x600. Try this (untested): > Ah thanks! your patch works for me. Is this one of the static entries in > the ACPI tables ? I am wondering if we can read this value so it works for > everybody. > Yes, it's PM1a_STS from the PM1a_EVT block; the pointer is in the FADT. x86/s3.c already has code to look for the FADT, so a fix should be easy. On top of that we should move the ACPI tables to a header and the parsing code to lib/x86, so that the vmexit test can use it to find the PM_TMR address. Paolo