All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jonathan Cameron <jic23@kernel.org>
To: Irina Tirdea <irina.tirdea@intel.com>, linux-iio@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, Hartmut Knaack <knaack.h@gmx.de>,
	Vlad Dogaru <vlad.dogaru@intel.com>
Subject: Re: [PATCH 1/2] iio: magn: bmc150_magn: add locking comment for runtime resume
Date: Sun, 2 Aug 2015 18:19:30 +0100	[thread overview]
Message-ID: <55BE5122.2060405@kernel.org> (raw)
In-Reply-To: <1437671702-20994-2-git-send-email-irina.tirdea@intel.com>

On 23/07/15 18:15, Irina Tirdea wrote:
> Runtime resume function is called with the data->mutex lock held.
> Add a comment to indicate this.
> 
> Signed-off-by: Irina Tirdea <irina.tirdea@intel.com>
Sensible follow up to Hartmut's patches.  

Applied to the togreg branch of iio.git

Thanks,

Jonathan
> ---
>  drivers/iio/magnetometer/bmc150_magn.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/iio/magnetometer/bmc150_magn.c b/drivers/iio/magnetometer/bmc150_magn.c
> index 074a99d..d66f8cf 100644
> --- a/drivers/iio/magnetometer/bmc150_magn.c
> +++ b/drivers/iio/magnetometer/bmc150_magn.c
> @@ -1043,6 +1043,9 @@ static int bmc150_magn_runtime_suspend(struct device *dev)
>  	return 0;
>  }
>  
> +/*
> + * Should be called with data->mutex held.
> + */
>  static int bmc150_magn_runtime_resume(struct device *dev)
>  {
>  	struct iio_dev *indio_dev = i2c_get_clientdata(to_i2c_client(dev));
> 


  reply	other threads:[~2015-08-02 17:19 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-23 17:15 [PATCH 0/2] bmc150 magnetometer cleanup Irina Tirdea
2015-07-23 17:15 ` [PATCH 1/2] iio: magn: bmc150_magn: add locking comment for runtime resume Irina Tirdea
2015-08-02 17:19   ` Jonathan Cameron [this message]
2015-07-23 17:15 ` [PATCH 2/2] iio: magn: bmc150_magn: do not set power state twice when setting trigger state Irina Tirdea
2015-08-02 17:20   ` Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55BE5122.2060405@kernel.org \
    --to=jic23@kernel.org \
    --cc=irina.tirdea@intel.com \
    --cc=knaack.h@gmx.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=vlad.dogaru@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.