From: Max Reitz <mreitz@redhat.com>
To: "Daniel P. Berrange" <berrange@redhat.com>, qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PATCH RFC 03/10] maint: remove / fix many doubled words
Date: Mon, 3 Aug 2015 18:10:12 +0200 [thread overview]
Message-ID: <55BF9264.7090706@redhat.com> (raw)
In-Reply-To: <1438360263-25445-4-git-send-email-berrange@redhat.com>
On 31.07.2015 18:30, Daniel P. Berrange wrote:
> Many source files have doubled words (eg "the the", "to to",
> and so on). Most of these can simply be removed, but a couple
> were actual mis-spellings (eg "to to" instead of "to do").
> There was even one triple word score "to to to" :-)
>
> Signed-off-by: Daniel P. Berrange <berrange@redhat.com>
> ---
> block/qcow2-cluster.c | 4 ++--
> block/qcow2-refcount.c | 2 +-
> cfg.mk | 4 +++-
> docs/libcacard.txt | 4 ++--
> docs/multiseat.txt | 2 +-
> docs/specs/qcow2.txt | 2 +-
> docs/specs/rocker.txt | 2 +-
> hw/net/rtl8139.c | 2 +-
> hw/usb/host-libusb.c | 2 +-
> hw/vfio/common.c | 2 +-
> include/block/block.h | 2 +-
> include/exec/memory.h | 2 +-
> linux-user/elfload.c | 2 +-
> migration/rdma.c | 2 +-
> qemu-doc.texi | 2 +-
> qemu-img.texi | 2 +-
> qemu-options.hx | 2 +-
> target-arm/cpu.h | 4 ++--
> target-arm/helper.c | 2 +-
> target-arm/translate.c | 2 +-
> target-lm32/helper.c | 2 +-
> target-microblaze/translate.c | 2 +-
> target-moxie/helper.c | 2 +-
> util/bitmap.c | 2 +-
> 24 files changed, 29 insertions(+), 27 deletions(-)
>
> diff --git a/block/qcow2-cluster.c b/block/qcow2-cluster.c
> index b43f186..a7337e6 100644
> --- a/block/qcow2-cluster.c
> +++ b/block/qcow2-cluster.c
> @@ -498,7 +498,7 @@ int qcow2_get_cluster_offset(BlockDriverState *bs, uint64_t offset,
>
> *cluster_offset = 0;
>
> - /* seek the the l2 offset in the l1 table */
> + /* seek the l2 offset in the l1 table */
>
> l1_index = offset >> l1_bits;
> if (l1_index >= s->l1_size) {
> @@ -612,7 +612,7 @@ static int get_cluster_table(BlockDriverState *bs, uint64_t offset,
> uint64_t *l2_table = NULL;
> int ret;
>
> - /* seek the the l2 offset in the l1 table */
> + /* seek the l2 offset in the l1 table */
>
> l1_index = offset >> (s->l2_bits + s->cluster_bits);
> if (l1_index >= s->l1_size) {
> diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
> index b0ee42d..2fd915f 100644
> --- a/block/qcow2-refcount.c
> +++ b/block/qcow2-refcount.c
> @@ -1294,7 +1294,7 @@ static int realloc_refcount_array(BDRVQcowState *s, void **array,
> /*
> * Increases the refcount for a range of clusters in a given refcount table.
> * This is used to construct a temporary refcount table out of L1 and L2 tables
> - * which can be compared the the refcount table saved in the image.
> + * which can be compared the refcount table saved in the image.
> *
> * Modifies the number of errors in res.
> */
I think all of the three hunks above should actually replace the first
"the" with a "to" instead of removing it.
Max
next prev parent reply other threads:[~2015-08-03 16:36 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-31 16:30 [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 01/10] tests: import GNULIB's syntax-check infrastructure Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 02/10] maint: remove double semicolons in many files Daniel P. Berrange
2015-08-13 17:57 ` Peter Maydell
2015-08-14 8:32 ` Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 03/10] maint: remove / fix many doubled words Daniel P. Berrange
2015-08-03 16:10 ` Max Reitz [this message]
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 04/10] maint: remove unused include for assert.h Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 05/10] maint: remove unused include for dirent.h Daniel P. Berrange
2015-07-31 16:30 ` [Qemu-devel] [PATCH RFC 06/10] maint: remove unused include for signal.h Daniel P. Berrange
2015-07-31 16:31 ` [Qemu-devel] [PATCH RFC 07/10] maint: remove unused include for strings.h Daniel P. Berrange
2015-07-31 16:31 ` [Qemu-devel] [PATCH RFC 08/10] maint: avoid useless "if (foo) free(foo)" pattern Daniel P. Berrange
2015-07-31 16:31 ` [Qemu-devel] [PATCH RFC 09/10] maint: add check for use of POSIX functions which are not reentrant safe Daniel P. Berrange
2015-07-31 16:31 ` [Qemu-devel] [PATCH RFC 10/10] maint: enable checking for qemu/osdep.h header usage Daniel P. Berrange
2015-08-13 17:53 ` [Qemu-devel] [PATCH RFC 00/10] Enable repository wide style checking Peter Maydell
2015-08-13 18:27 ` Eric Blake
2015-08-13 20:39 ` Peter Maydell
2015-08-14 9:57 ` Daniel P. Berrange
2015-08-14 10:30 ` Paul Eggert
2015-08-14 10:35 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BF9264.7090706@redhat.com \
--to=mreitz@redhat.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.