Re: [PATCH] cpuidle/coupled: Init cpuidle_device::safe_state_index

[Daniel Lezcano <daniel.lezcano@linaro.org>]

On 07/23/2015 02:31 PM, Xunlei Pang wrote:
> From: Xunlei Pang <pang.xunlei@zte.com.cn>
>
> cpuidle_device::safe_state_index need to be initialized before use,
> so assign the driver's safe_state_index to it.
>
> Signed-off-by: Xunlei Pang <pang.xunlei@zte.com.cn>
> ---
>   drivers/cpuidle/cpuidle.c | 2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c
> index e8e2775..ed5c8efe 100644
> --- a/drivers/cpuidle/cpuidle.c
> +++ b/drivers/cpuidle/cpuidle.c
> @@ -585,6 +585,8 @@ int cpuidle_register(struct cpuidle_driver *drv,
>   		 */
>   		if (coupled_cpus)
>   			device->coupled_cpus = *coupled_cpus;
> +
> +		device->safe_state_index = drv->safe_state_index;

Hey, good catch. We are lucky the safe_state_index is always zero.

I think we can simplify the code by removing the safe_state_index from 
the cpuidle_device structure and use the one in the cpuidle_driver 
structure in coupled.c




-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog