From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 2263AE00A01; Mon, 3 Aug 2015 09:59:00 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.182 listed in list.dnswl.org] Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com [209.85.212.182]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 0FA99E00902 for ; Mon, 3 Aug 2015 09:58:55 -0700 (PDT) Received: by wicgj17 with SMTP id gj17so114244631wic.1 for ; Mon, 03 Aug 2015 09:58:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :cc:subject:references:in-reply-to:content-type :content-transfer-encoding; bh=w62rjc1YNqSW1gHhvlJkMUIXtlOF5efg68ETKY+WGIU=; b=ZvGD7jXVuiBD9nx9bwaH3ui9jsGrkuzFfbFxH0wNKZE+mf8eWacWZ5u7VRNceIHAs9 e/hn3MC8uVcxd/FIOBWBNT6Qm6uPPIw+r89w9jGrBwBlGpzTlYN5gMTrL7WsssIF5Tue MS9Z2KW/M5CnQtDoUA4qNc8g30QK+zsNzGA9jjQ6zxlcraOe8BGJS03HqOYj6oz9q1tq BvYepv6X7csxn9EidVCk9WSD/BTIEVyY7MiySEdW+Dc1wfRrAyB78kqb/FcsMqlAF1r0 CVA12jNx1tCblrF3MsyUqRDUehoYjiaw5ar3Sb9/qUh9ME9QyGf87BOv0JyNlnYSwtKP ROLg== X-Gm-Message-State: ALoCoQlcXLwvsDGqrFpWmv8YFgKHcTdeHFQqHxsOV1FuyA9P/zeOUhjSvmlWHn5mg0jdzTSOIOki X-Received: by 10.180.87.99 with SMTP id w3mr34786338wiz.4.1438621134615; Mon, 03 Aug 2015 09:58:54 -0700 (PDT) Received: from [192.168.2.72] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id lm5sm14456423wic.22.2015.08.03.09.58.53 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 09:58:53 -0700 (PDT) Message-ID: <55BF9DCC.9020002@intel.com> Date: Mon, 03 Aug 2015 17:58:52 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: toaster@yoctoproject.org References: In-Reply-To: Subject: Re: [review-request] bbarrosp/nav-project-changes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 16:59:00 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit On 03/08/15 11:23, Barros Pena, Belen wrote: > Some tiny tweaks to the project pages after Michael's sweeping changes. > > http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp/n > av-project-changes > > bitbake: toastergui: spacing and top nav style change > > 03d81dd9114073037207a30a9cb896ad06e50f95 > > > bitbake: toastergui: breadcrumb fixes > > 6dd1d2325ffb70754a1b4cd5b7006176d148ba85 To improve this code further you can use single quotes instead of having to escape the double quotes. e.g. .append('→'); > > bitbake: toastergui: change link styles in alert-info > > acfc0dfda16bf9edcefb2dfefaea2f44cc7e635d > > bitbake: toastergui: remove project name from layer change notification > > c3606313e53c7614a09a065b9f4463363053d62a If we don't need the project name and link can you also remove where the project name and link are set i.e. these two lines: alertMsg.children("#project-affected-name").text(libtoaster.ctx.projectName); alertMsg.children("#project-affected-name").attr("href", libtoaster.ctx.projectPageUrl); > > bitbake: toastergui: fix spacing in the import layers page > > f5d3d554d20eaaa36e4a9e4e281567f82ed66c17 > > bitbake: toastergui: add action to empty "most built" recipes > > 79ce966108ecea344e29a5ccece8f7a09f23d047 > > Thanks! > > Belén Everything else looks fine, Thanks! Michael