From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 41CFBE009C3; Mon, 3 Aug 2015 10:49:06 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.178 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 49F7AE0034B for ; Mon, 3 Aug 2015 10:49:01 -0700 (PDT) Received: by wibxm9 with SMTP id xm9so124610065wib.1 for ; Mon, 03 Aug 2015 10:49:00 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=imqcdNLkQGGnauIdUZ1UCDN4KWPSt2U9VzJen9b4WoY=; b=Tb2hNG9tICf1hjapWGLVnLf8Os/kncRv4lV3TfLI2FukLR7dRl8BayP2RiHqcLdgEa 9S0tpP8s+Hvu8fM80TOTY+QXLGN08cvYXM1+lKseZt/alVCwxkSLxS0yzz9EhhWL2cwa K8fx2FUvPV3TAH3k3TDp96+mKXN8BXV2NFKixWVDwKiDzOKb/lkUY3HZggBQ/vgtSfHA Mzjj+Tzkafq52xyGK9EDcn08u/kBbGzsS+mfxHyX/o7LcQV+e6dhgSau7Xmot5i98b1Y 7LOR5+/EbGB7CkVnfXto2dwg/+mxfcDiETkLdJJA/WIWK1Dq7NqGDQ7PcZQpOn/Rd4yW hb8w== X-Gm-Message-State: ALoCoQkPv7hscnCYnBldC/ILXMq/DvzvTv5/gsmhV7jTTcX7EvTNPHnzDjVu4ScheGXLnti9d5zd X-Received: by 10.194.78.84 with SMTP id z20mr38538652wjw.141.1438624139604; Mon, 03 Aug 2015 10:48:59 -0700 (PDT) Received: from [192.168.2.72] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id k4sm14648079wix.19.2015.08.03.10.48.58 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 03 Aug 2015 10:48:58 -0700 (PDT) Message-ID: <55BFA989.4040406@intel.com> Date: Mon, 03 Aug 2015 18:48:57 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: "Barros Pena, Belen" , "toaster@yoctoproject.org" References: <55BF951C.3000108@intel.com> In-Reply-To: Subject: Re: [review-request] michaelw/toaster/fix-typeahead-behaviour X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Aug 2015 17:49:06 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Please ignore this review-request I will submit a V2 as there was a typo in the models.py util function that Belen discovered. We have also talked about how best to do the typeahead matching behaviour so that can be done to closer to the design without a whole lot of extra work. Thanks, Michael On 03/08/15 17:58, Barros Pena, Belen wrote: > > On 03/08/2015 17:21, "toaster-bounces@yoctoproject.org on behalf of > Michael Wood" michael.g.wood@intel.com> wrote: > >> This branch brings back the correct typeahead behaviour as a modular >> widget. >> >> - New typeahead widget >> - Switch to Implementation of widget in frontend >> - Utility functions in the models so that the querysets which are used >> for the ToasterTables are the same queries that are used for the >> typeaheads. >> - Added/Fixed typeahead widget unit tests >> >> see also https://bugzilla.yoctoproject.org/show_bug.cgi?id=7152 > All the typeaheads work, although not as required by the design document > attached to 7152. > > I think we should send this upstream though, and fix 7152 separately. > > Thanks! > > Belén > >> * a465b19 bitbake: toastergui: tests Fix and more comprehensive >> typeahead unittest >> * 4c71133 bitbake: toastergui: views Standardise the fields project >> layer response >> * 592339b bitbake: toasterui: views Remove unused xhr_typeahead view >> definition >> * dc7d764 bitbake: toastergui: libtoaster Throw an exception no url is >> specified >> * 94c3f72 bitbake: toastergui: Switch to using the new toaster typeahead >> widget >> * ead8702 bitbake: toastergui: Add typeaheads for layers, machines and >> recipes >> * 09c6772 bitbake: toastergui: widgets Add a typeahead widget >> * 9309429 bitbake: toastergui: tables Use util functions for the common >> querysets >> * 0ba647b bitbake: toaster: orm Add util functions to return common >> querysets >> * 691696f bitbake: toaster: orm Add util function to return the url to >> layerversion >> >> >> >> >> -- >> _______________________________________________ >> toaster mailing list >> toaster@yoctoproject.org >> https://lists.yoctoproject.org/listinfo/toaster