Re: [Qemu-devel] [PATCH] migration: Make events a capability

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]

On 07/07/2015 06:47 AM, Juan Quintela wrote:
> Make check fails with events.  THis is due to the parser/lexer that it
> uses.  Just in case that they are more broken parsers, just only send
> events when there are capabilities.
> 
> Signed-off-by: Juan Quintela <quintela@redhat.com>
> ---
>  include/migration/migration.h |  1 +
>  migration/migration.c         | 20 ++++++++++++++++++--
>  qapi-schema.json              |  5 ++++-
>  3 files changed, 23 insertions(+), 3 deletions(-)
> 

> +++ b/qapi-schema.json
> @@ -523,6 +523,9 @@
>  #          minimize migration traffic. The feature is disabled by default.
>  #          (since 2.4 )

Copying from pre-existing...

>  #
> +# @events: generate events for each migration state change
> +#          (since 2.4 )

...but the space before ) looks odd.  A trivial followup patch may be in
order, but no need to hold up 2.4 for it.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]