From: Eric Sandeen <sandeen@sandeen.net>
To: Dave Chinner <david@fromorbit.com>, xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] libxfs: fix uuid check durign inode allocation
Date: Mon, 03 Aug 2015 15:29:23 -0700 [thread overview]
Message-ID: <55BFEB43.3030002@sandeen.net> (raw)
In-Reply-To: <1438587749-31597-3-git-send-email-david@fromorbit.com>
On 8/3/15 12:42 AM, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> Needs to check sb_meta_uuid now that we the sb_uuid can change on v5
> filesystems.
>
> Signed-off-by: Dave Chinner <dchinner@redhat.com>
ASSERTs are off in libxfs anyway right? Still:
Reviewed-by: Eric Sandeen <sandeen@redhat.com>
> ---
> libxfs/util.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libxfs/util.c b/libxfs/util.c
> index 719a5b7..f427d22 100644
> --- a/libxfs/util.c
> +++ b/libxfs/util.c
> @@ -262,7 +262,7 @@ libxfs_ialloc(
>
> if (ip->i_d.di_version == 3) {
> ASSERT(ip->i_d.di_ino == ino);
> - ASSERT(uuid_equal(&ip->i_d.di_uuid, &mp->m_sb.sb_uuid));
> + ASSERT(uuid_equal(&ip->i_d.di_uuid, &mp->m_sb.sb_meta_uuid));
> ip->i_d.di_crc = 0;
> ip->i_d.di_changecount = 1;
> ip->i_d.di_lsn = 0;
>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2015-08-03 22:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 7:42 [PATCH 0/2] xfsprogs: sb_meta_uuid fixes Dave Chinner
2015-08-03 7:42 ` [PATCH 1/2] repair: use sb_meta_uuid for checking of metadata headers Dave Chinner
2015-08-03 22:28 ` Eric Sandeen
2015-08-03 7:42 ` [PATCH 2/2] libxfs: fix uuid check durign inode allocation Dave Chinner
2015-08-03 22:29 ` Eric Sandeen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55BFEB43.3030002@sandeen.net \
--to=sandeen@sandeen.net \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.