From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from a.ns.miles-group.at ([95.130.255.143] helo=radon.swed.at) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZMWXp-0004RG-Bi for linux-mtd@lists.infradead.org; Tue, 04 Aug 2015 07:21:54 +0000 Subject: Re: [RFC PATCH 2/2] mtd: nand: use nand_check_erased_ecc_chunk in default ECC read functions To: Andrea Scian , Boris Brezillon References: <1438277694-23763-3-git-send-email-boris.brezillon@free-electrons.com> <55BB48D9.6050508@dave-tech.it> <20150731123221.34cf601e@bbrezillon> <55BB7ABD.7040008@dave-tech.it> <20150731161032.2b155ccb@bbrezillon> <55BBA012.4080600@dave-tech.it> <20150731182709.14c345df@bbrezillon> <55BF4D72.8090000@dave-tech.it> <20150803144253.66fc6941@bbrezillon> <55BF6F09.9000001@dave-tech.it> <55BFC1DA.3090108@nod.at> <55C06379.5090705@dave-tech.it> Cc: linux-mtd@lists.infradead.org, David Woodhouse , Brian Norris , linux-kernel@vger.kernel.org, Han Xu , Artem Bityutskiy From: Richard Weinberger Message-ID: <55C067F7.3000309@nod.at> Date: Tue, 4 Aug 2015 09:21:27 +0200 MIME-Version: 1.0 In-Reply-To: <55C06379.5090705@dave-tech.it> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Andrea, Am 04.08.2015 um 09:02 schrieb Andrea Scian: >> I'm not sure whether introducing a read-before-write check is the best solution. >> At least we need hard numbers for slow/old SLC NANDs too. > > We can enable the feature only for MLC, AFAIK it has not been required for old SLC ;-) I think this needs more discussion. Boris, Brian, will you be at Embedded Linux Conference Europe in Dublin? Maybe we can discuss these issues (data retention, ff-checks, etc...) in person and figure out where to address them. I really want to avoid ad-hoc solutions. :) > Thanks. > In your opinion, enabling chk_io is correct to rough estimate the overhead or does it enable too much checks? You mean the other checks bedside of self_check_write()? You can comment them out for your tests. Thanks, //richard