From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tang Chen Subject: Re: [PATCH 1/5] x86, gfp: Cache best near node for memory allocation. Date: Tue, 4 Aug 2015 16:58:47 +0800 Message-ID: <55C07EC7.3040301@cn.fujitsu.com> References: <1436261425-29881-1-git-send-email-tangchen@cn.fujitsu.com>, <1436261425-29881-2-git-send-email-tangchen@cn.fujitsu.com>, <20150715214802.GL15934@mtj.duckdns.org>, <55C03332.2030808@cn.fujitsu.com> <201508041626380745999@inspur.com> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary="------------080805040207090808020608" Return-path: In-Reply-To: <201508041626380745999@inspur.com> Sender: owner-linux-mm@kvack.org To: "gongzhaogang@inspur.com" , "tj@kernel.org" Cc: "mingo@redhat.com" , "akpm@linux-foundation.org" , "rjw@rjwysocki.net" , "hpa@zytor.com" , tangchen@cn.fujitsu.com, "yasu.isimatu@gmail.com" , "isimatu.yasuaki@jp.fujitsu.com" , "kamezawa.hiroyu@jp.fujitsu.com" , "izumi.taku@jp.fujitsu.com" , "qiaonuohan@cn.fujitsu.com" , "x86@kernel.org" , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" List-Id: linux-acpi@vger.kernel.org --------------080805040207090808020608 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit On 08/04/2015 04:26 PM, gongzhaogang@inspur.com wrote: > Sorry,I am new. > >But, > >1) in cpu_up(), it will try to online a node, and it doesn't check if > >the node has memory. > >2) in try_offline_node(), it offlines CPUs first, and then the memory. > >This behavior looks a little wired, or let's say it is ambiguous. It > >seems that a NUMA node > >consists of CPUs and memory. So if the CPUs are online, the node should > >be online. > I suggested you to try the patch offered by Liu Jiang. > > https://lkml.org/lkml/2014/9/11/1087 > Well, I think Liu Jiang meant this patch set. :) https://lkml.org/lkml/2014/7/11/75 > I have tried ,It is OK. > > >Unfortunately, since I don't have a machine a with memory-less node, I > >cannot reproduce > >the problem right now. > > If not hurried , I can test your patches in our environment on weekends. > Thanks. But this version of my patch set is obviously problematic. It will be very nice of you if you can help to test the next version. But maybe in a few days. Thanks. :) --------------080805040207090808020608 Content-Type: text/html; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit
On 08/04/2015 04:26 PM, gongzhaogang@inspur.com wrote:
Sorry,I am new.
>But,
>1) in cpu_up(), it will try to online a node, and it doesn't check if
>the node has memory.
>2) in try_offline_node(), it offlines CPUs first, and then the memory.
 
>This behavior looks a little wired, or let's say it is ambiguous. It
>seems that a NUMA node
>consists of CPUs and memory. So if the CPUs are online, the node should
>be online.
I suggested you to try the patch offered by Liu Jiang.



Well, I think Liu Jiang meant this patch set. :)

https://lkml.org/lkml/2014/7/11/75

I have tried ,It is OK.

>Unfortunately, since I don't have a machine a with memory-less node, I
>cannot reproduce
>the problem right now.

If  not hurried  , I can test your patches in our environment on weekends.

Thanks. But this version of my patch set is obviously problematic.
It will be very nice of you if you can help to test the next version.
But maybe in a few days.

Thanks. :)
--------------080805040207090808020608-- -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: email@kvack.org