From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH for-4.6 v2 2/6] docs/libxl: Re-specify
 XENSTORE_DATA as EMULATOR_XENSTORE_DATA
Date: Tue, 4 Aug 2015 11:16:08 +0100
Message-ID: <55C090E8.7070808@citrix.com>
References: <1438617395-20329-1-git-send-email-andrew.cooper3@citrix.com>
	<1438617395-20329-3-git-send-email-andrew.cooper3@citrix.com>
	<1438681238.31129.68.camel@citrix.com> <55C08923.2000009@citrix.com>
	<1438682810.31129.86.camel@citrix.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <1438682810.31129.86.camel@citrix.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Ian Campbell <ian.campbell@citrix.com>, Xen-devel <xen-devel@lists.xen.org>
Cc: Wei Liu <wei.liu2@citrix.com>, Ian Jackson <Ian.Jackson@eu.citrix.com>
List-Id: xen-devel@lists.xenproject.org

On 04/08/15 11:06, Ian Campbell wrote:
>
>>>> +
>>>> +     0     1     2     3     4     5     6     7 octet
>>>> +    +------------------------+------------------------+
>>>> +    | emulator_id            | index                  |
>>>> +    +------------------------+------------------------+
>>>> +    | record specific data                            |
>>>> +    ...
>>>> +    +-------------------------------------------------+
>>>> +
>>>> +--------------------------------------------------------------------
>>>> +Field            Description
>>>> +------------     ---------------------------------------------------
>>>> +emulator_id      0x00000000: Unknown (In the case of a legacy 
>>>> stream)
>>>> +
>>>> +                 0x00000001: Qemu Traditional
>>>> +
>>>> +                 0x00000002: Qemu Upstream
>>>> +
>>>> +                 0x00000003 - 0xFFFFFFFF: Reserved for future 
>>>> emulators.
>>>> +
>>>> +index            Index of this emulator for the domain, if multiple
>>>> +                 emulators are in use.
>>> This is old wording, but what value does this take if no emulators are 
>>> in
>>> use? If the answer is "undefined" then I suppose there is a field 
>>> somewhere
>>> else which indicates the number of emulators?
>> If no emulators are in use, the record is not sent in the first place.
> Sorry, I meant no multiple emulators. Which is a complicated way of saying
> one...
>
> I saw in a later patch that this field appears to be zero then, which is
> reasonable and removes the need to treat multiple emulators specially. IOW
> I think you could just remove the second clause above.

Ah yes - I will make that adjustment.

~Andrew