All of lore.kernel.org
 help / color / mirror / Atom feed
From: Guoqing Jiang <gqJiang@suse.com>
To: Adam Goryachev <mailinglists@websitemanagers.com.au>
Cc: Goldwyn Rodrigues <rgoldwyn@suse.com>,
	neilb@suse.com, linux-raid@vger.kernel.org
Subject: Re: [PATCH 1/2] Safeguard against writing to an active device of another node
Date: Tue, 04 Aug 2015 18:23:34 +0800	[thread overview]
Message-ID: <55C092A6.5040202@suse.com> (raw)
In-Reply-To: <55C0918A.7010808@websitemanagers.com.au>

Adam Goryachev wrote:
> On 04/08/15 20:05, Guoqing Jiang wrote:
>   
>> Hi Goldwyn,
>>
>> Thanks for review.
>>
>> Goldwyn Rodrigues wrote:
>>     
>>>> +    set_dlm_hookers(); /* get dlm funcs from libdlm_lt.so.3 */
>>>> +
>>>>         
>>> Universal Comment: Let call it set_dlm_hooks as opposed to hookers.
>>>
>>>       
>> Not sure I understood correctly, the second patch used set_hookers to
>> call set_dlm_hookers.
>>     
>
> I think Neil meant to ask you to please do a global s/hookers/hooks/
> because hooker has a particular meaning in english which is different to
> what you intended.
> http://www.urbandictionary.com/define.php?term=hooker
>
> Hope that helps.
>   
Got it, thanks for the website, will change it.

Thanks,
Guoqing



      reply	other threads:[~2015-08-04 10:23 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-03 11:31 [PATCH 1/2] Safeguard against writing to an active device of another node Guoqing Jiang
2015-08-03 11:31 ` [PATCH 2/2] Make cmap_* also has same policy as dlm_* Guoqing Jiang
2015-08-03 11:58   ` Goldwyn Rodrigues
2015-08-04 10:09     ` Guoqing Jiang
2015-08-03 11:56 ` [PATCH 1/2] Safeguard against writing to an active device of another node Goldwyn Rodrigues
2015-08-04 10:05   ` Guoqing Jiang
2015-08-04 10:18     ` Adam Goryachev
2015-08-04 10:23       ` Guoqing Jiang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55C092A6.5040202@suse.com \
    --to=gqjiang@suse.com \
    --cc=linux-raid@vger.kernel.org \
    --cc=mailinglists@websitemanagers.com.au \
    --cc=neilb@suse.com \
    --cc=rgoldwyn@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.