From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Date: Tue, 04 Aug 2015 13:40:21 +0000 Subject: Re: [patch] mpls: small cleanup in inet/inet6_fib_lookup_dev() Message-Id: <55C0C0C5.1040901@cumulusnetworks.com> List-Id: References: <20150804074422.GB10867@mwanda> In-Reply-To: <20150804074422.GB10867@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: "David S. Miller" , "Eric W. Biederman" , Robert Shearman , Tom Herbert , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org On 8/4/15, 12:44 AM, Dan Carpenter wrote: > We recently changed this code from returning NULL to returning ERR_PTR. > There are some left over NULL assignments which we can remove. We can > preserve the error code from ip_route_output() instead of always > returning -ENODEV. Also these functions use a mix of gotos and direct > returns. There is no cleanup necessary so I changed the gotos to > direct returns. > > Signed-off-by: Dan Carpenter > Acked-by: Roopa Prabhu From mboxrd@z Thu Jan 1 00:00:00 1970 From: roopa Subject: Re: [patch] mpls: small cleanup in inet/inet6_fib_lookup_dev() Date: Tue, 04 Aug 2015 06:40:21 -0700 Message-ID: <55C0C0C5.1040901@cumulusnetworks.com> References: <20150804074422.GB10867@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: "David S. Miller" , "Eric W. Biederman" , Robert Shearman , Tom Herbert , netdev@vger.kernel.org, kernel-janitors@vger.kernel.org To: Dan Carpenter Return-path: In-Reply-To: <20150804074422.GB10867@mwanda> Sender: kernel-janitors-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 8/4/15, 12:44 AM, Dan Carpenter wrote: > We recently changed this code from returning NULL to returning ERR_PTR. > There are some left over NULL assignments which we can remove. We can > preserve the error code from ip_route_output() instead of always > returning -ENODEV. Also these functions use a mix of gotos and direct > returns. There is no cleanup necessary so I changed the gotos to > direct returns. > > Signed-off-by: Dan Carpenter > Acked-by: Roopa Prabhu