From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: by yocto-www.yoctoproject.org (Postfix, from userid 118) id 27831E00A92; Tue, 4 Aug 2015 08:10:36 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on yocto-www.yoctoproject.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=5.0 tests=BAYES_00,RCVD_IN_DNSWL_LOW autolearn=ham version=3.3.1 X-Spam-HAM-Report: * -0.7 RCVD_IN_DNSWL_LOW RBL: Sender listed at http://www.dnswl.org/, low * trust * [209.85.212.171 listed in list.dnswl.org] * -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% * [score: 0.0000] Received: from mail-wi0-f171.google.com (mail-wi0-f171.google.com [209.85.212.171]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id B2936E009C5 for ; Tue, 4 Aug 2015 08:10:31 -0700 (PDT) Received: by wicgj17 with SMTP id gj17so154881914wic.1 for ; Tue, 04 Aug 2015 08:10:31 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:message-id:date:from:user-agent:mime-version:to :subject:references:in-reply-to:content-type :content-transfer-encoding; bh=9BwFwOFfonBD/bwi5cAr06HpTKYgZekls/lP5h6fnvI=; b=DJgr+pNx6V9mdGT6nOA8gSY2Yup8Z3qDFmnn+3CGzxZQpZPXG25f1KYj6ivIo2bkn6 Upu8L2rMkLO+dmFXmxER3ow3hpDtJ88qhXk+1f+C85zi36dxXZOOJVCcQrhuTEMea0U3 l/Zx2RScUoPcOYw3Fu//UpGNlgLXTP9aDyZsVPltiUsjNdJfTEQIX60UU4YDPfIAvChj AaxgqsSSO7MFo0SHeyconstMKiSnxnjgt+sC0P+Gy0itDf/H7rH8z4gqLUbm4S5PaFWU bPmcFMsltlW1mr0UfosXp1NlLHYc3G5tyJCeUrKm8SUUJDmE0EDQYACJ06cKUEbT7jMp g8Tg== X-Gm-Message-State: ALoCoQmieVvwbXGVkh0qdNGzFghqAfIvShSaHR97MWBnJViNOcT3VpHAHbpabMJvRgqbu0BN7cDS X-Received: by 10.194.78.143 with SMTP id b15mr9930798wjx.88.1438701031245; Tue, 04 Aug 2015 08:10:31 -0700 (PDT) Received: from [192.168.2.72] ([83.217.123.106]) by smtp.googlemail.com with ESMTPSA id d7sm2887115wij.0.2015.08.04.08.10.30 for (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 04 Aug 2015 08:10:30 -0700 (PDT) Message-ID: <55C0D5E6.9010401@intel.com> Date: Tue, 04 Aug 2015 16:10:30 +0100 From: Michael Wood User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: toaster@yoctoproject.org References: In-Reply-To: Subject: Re: [review-request] [v2] bbarrosp/nav-project-changes X-BeenThere: toaster@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Web based interface for BitBake List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Aug 2015 15:10:36 -0000 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Thanks submitted to bitbake (with white space fix on bitbake: toastergui: spacing and top nav style change) On 04/08/15 10:48, Barros Pena, Belen wrote: > Thanks for the review: all changes made. Same branch: > > bbarrosp/nav-project-changes > > bitbake: toastergui: add action to empty "most built" recipes > 79ce966108ecea344e29a5ccece8f7a09f23d047 > > bitbake: toastergui: fix spacing in the import layers page > f5d3d554d20eaaa36e4a9e4e281567f82ed66c17 > > > bitbake: toastergui: remove project name from layer change notification > c3606313e53c7614a09a065b9f4463363053d62a > > > bitbake: toastergui: change link styles in alert-info > acfc0dfda16bf9edcefb2dfefaea2f44cc7e635d > > > bitbake: toastergui: breadcrumb fixes > 6dd1d2325ffb70754a1b4cd5b7006176d148ba85 > > > > bitbake: toastergui: spacing and top nav style change > 03d81dd9114073037207a30a9cb896ad06e50f95 > > Cheers > > Belén > > > > > On 03/08/2015 17:58, "Michael Wood" wrote: > >> On 03/08/15 11:23, Barros Pena, Belen wrote: >>> Some tiny tweaks to the project pages after Michael's sweeping changes. >>> >>> >>> http://git.yoctoproject.org/cgit/cgit.cgi/poky-contrib/commit/?h=bbarrosp >>> /n >>> av-project-changes >>> >>> bitbake: toastergui: spacing and top nav style change >>> >>> 03d81dd9114073037207a30a9cb896ad06e50f95 >>> >>> >>> bitbake: toastergui: breadcrumb fixes >>> >>> 6dd1d2325ffb70754a1b4cd5b7006176d148ba85 >> To improve this code further you can use single quotes instead of having >> to escape the double quotes. >> >> e.g. >> >> .append('→'); >> >>> bitbake: toastergui: change link styles in alert-info >>> >>> acfc0dfda16bf9edcefb2dfefaea2f44cc7e635d >>> >>> bitbake: toastergui: remove project name from layer change notification >>> >>> c3606313e53c7614a09a065b9f4463363053d62a >> If we don't need the project name and link can you also remove where the >> project name and link are set i.e. these two lines: >> >> alertMsg.children("#project-affected-name").text(libtoaster.ctx.projectNam >> e); >> alertMsg.children("#project-affected-name").attr("href", >> libtoaster.ctx.projectPageUrl); >> >> >> >>> bitbake: toastergui: fix spacing in the import layers page >>> >>> f5d3d554d20eaaa36e4a9e4e281567f82ed66c17 >>> >>> bitbake: toastergui: add action to empty "most built" recipes >>> >>> 79ce966108ecea344e29a5ccece8f7a09f23d047 >>> >>> Thanks! >>> >>> Belén >> Everything else looks fine, Thanks! >> >> >> Michael