From: Stefan Schmidt <stefan@osg.samsung.com>
To: Alexander Aring <alex.aring@gmail.com>, linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: Re: [RFCv3 bluetooth-next 5/6] at86rf230: remove max_frame_retries -1 check
Date: Tue, 4 Aug 2015 18:42:32 +0200 [thread overview]
Message-ID: <55C0EB78.8060200@osg.samsung.com> (raw)
In-Reply-To: <1438246542-17633-6-git-send-email-alex.aring@gmail.com>
Hello.
On 30/07/15 10:55, Alexander Aring wrote:
> Since we remove the max_frame_retries "-1" option from mac802154 stack
> we don't need to check on such option as parameter.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> drivers/net/ieee802154/at86rf230.c | 6 +-----
> 1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
> index 8b9557f..0bb52b2 100644
> --- a/drivers/net/ieee802154/at86rf230.c
> +++ b/drivers/net/ieee802154/at86rf230.c
> @@ -1268,12 +1268,8 @@ static int
> at86rf230_set_frame_retries(struct ieee802154_hw *hw, s8 retries)
> {
> struct at86rf230_local *lp = hw->priv;
> - int rc = 0;
>
> - if (retries >= 0)
> - rc = at86rf230_write_subreg(lp, SR_MAX_FRAME_RETRIES, retries);
> -
> - return rc;
> + return at86rf230_write_subreg(lp, SR_MAX_FRAME_RETRIES, retries);
> }
>
> static int
Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>
regards
Stefan Schmidt
next prev parent reply other threads:[~2015-08-04 16:42 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-30 8:55 [RFCv3 bluetooth-next 0/6] ieee802154: aret handling changes Alexander Aring
2015-07-30 8:55 ` [RFCv3 bluetooth-next 1/6] mac802154: cfg: remove test and set checks Alexander Aring
2015-08-04 16:29 ` Stefan Schmidt
2015-07-30 8:55 ` [RFCv3 bluetooth-next 2/6] ieee802154: add helpers for frame control checks Alexander Aring
2015-08-04 16:29 ` Stefan Schmidt
2015-08-04 17:44 ` Alexander Aring
2015-08-04 18:35 ` Stefan Schmidt
2015-08-04 18:47 ` Alexander Aring
2015-08-05 8:47 ` Stefan Schmidt
2015-07-30 8:55 ` [RFCv3 bluetooth-next 3/6] at86rf230: use aret mode if ackreq is set while xmit Alexander Aring
2015-08-04 16:35 ` Stefan Schmidt
2015-07-30 8:55 ` [RFCv3 bluetooth-next 4/6] mac802154: change max_frame_retries behaviour Alexander Aring
2015-08-04 16:40 ` Stefan Schmidt
2015-08-04 18:00 ` Alexander Aring
2015-08-04 18:09 ` Alexander Aring
2015-08-05 8:46 ` Stefan Schmidt
2015-08-05 9:14 ` Alexander Aring
2015-07-30 8:55 ` [RFCv3 bluetooth-next 5/6] at86rf230: remove max_frame_retries -1 check Alexander Aring
2015-08-04 16:42 ` Stefan Schmidt [this message]
2015-07-30 8:55 ` [RFCv3 bluetooth-next 6/6] ieee802154: add ack request default handling Alexander Aring
2015-08-04 16:51 ` Stefan Schmidt
2015-08-04 16:28 ` [RFCv3 bluetooth-next 0/6] ieee802154: aret handling changes Stefan Schmidt
2015-08-04 18:42 ` Alexander Aring
2015-08-05 8:54 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C0EB78.8060200@osg.samsung.com \
--to=stefan@osg.samsung.com \
--cc=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.