Re: [Qemu-devel] [PATCH 18/26] tests/qapi-schema: Rename tests from data- to args-

[Eric Blake <eblake@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 2103 bytes --]

On 08/04/2015 03:18 AM, Markus Armbruster wrote:
> Since every schema entity has 'data', the data- prefix conveys no
> information.  These tests actually exercise commands.  Only commands
> have arguments, so change the prefix to to args-.
> 
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
>  tests/Makefile                                                      | 6 +++---
>  tests/qapi-schema/{data-array-empty.err => args-array-empty.err}    | 2 +-
>  tests/qapi-schema/{data-unknown.exit => args-array-empty.exit}      | 0
>  tests/qapi-schema/{data-array-empty.json => args-array-empty.json}  | 0

git rename detection doesn't work too well when renaming identical
contents :)  Thankfully, it all works out in the end, and the Makefile
changes are the easiest way to review this.  And thank goodness that git
compresses renames in patches; this email would have been a lot longer
by traditional diff.

> diff --git a/tests/Makefile b/tests/Makefile
> index 7494582..0f01b5c 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -229,9 +229,9 @@ check-qapi-schema-y := $(addprefix tests/qapi-schema/, \
>  	redefined-type.json redefined-command.json redefined-builtin.json \
>  	redefined-event.json command-int.json bad-data.json event-max.json \
>  	type-bypass.json type-bypass-no-gen.json type-bypass-bad-gen.json \
> -	data-array-empty.json data-array-unknown.json data-int.json \
> -	data-unknown.json data-member-unknown.json data-member-array.json \
> -	data-member-array-bad.json returns-array-bad.json returns-int.json \
> +	args-array-empty.json args-array-unknown.json args-int.json \
> +	args-unknown.json args-member-unknown.json args-member-array.json \
> +	args-member-array-bad.json returns-array-bad.json returns-int.json \
>  	returns-unknown.json returns-alternate.json returns-whitelist.json \

7 sets of files renamed, including fallout to the changed error messages.

Reviewed-by: Eric Blake <eblake@redhat.com>

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]