From: Stephen Boyd <sboyd@codeaurora.org>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Michael Turquette <mturquette@baylibre.com>,
linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org,
Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Subject: Re: [PATCH] clk: pxa: pxa3xx: fix CKEN register access
Date: Tue, 04 Aug 2015 10:58:54 -0700 [thread overview]
Message-ID: <55C0FD5E.7000705@codeaurora.org> (raw)
In-Reply-To: <87h9ofmv2n.fsf@belgarion.home>
On 08/03/2015 11:22 PM, Robert Jarzmik wrote:
> Stephen Boyd <sboyd@codeaurora.org> writes:
>
>> On 08/03/2015 12:58 PM, Robert Jarzmik wrote:
>>> Clocks 0 to 31 are on CKENA, and not CKENB. The clock register names
>>> were inadequately inverted. As a consequence, all clock operations were
>>> happening on CKENB, because almost all but 2 clocks are on CKENA.
>>>
>>> As the clocks were activated by the bootloader in the former tests, it
>>> escaped the testing that the wrong clock gate was manipulated. The error
>>> was revealed by changing the pxa3xx-and driver to a module, where tupon
>>> unloading the wrong clock was disabled in CKENB.
>>>
>>> Signed-off-by: Robert Jarzmik <robert.jarzmik@free.fr>
>>> ---
>> Did you want a fixes tag to send this back to stable?
> Ah yes, good point, v2 on its way.
>
> Stephen and Mike, do you think this can still get in -rc6 ?
>
It's not a new regression for v4.2 so we'll leave it to v4.3. I'll apply
it to clk-next.
--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
next prev parent reply other threads:[~2015-08-04 17:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 19:58 [PATCH] clk: pxa: pxa3xx: fix CKEN register access Robert Jarzmik
2015-08-04 0:42 ` Stephen Boyd
2015-08-04 6:22 ` Robert Jarzmik
2015-08-04 17:58 ` Stephen Boyd [this message]
2015-08-04 18:33 ` Robert Jarzmik
2015-08-04 19:00 ` Stephen Boyd
2015-08-04 19:05 ` Robert Jarzmik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55C0FD5E.7000705@codeaurora.org \
--to=sboyd@codeaurora.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=robert.jarzmik@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.