From mboxrd@z Thu Jan 1 00:00:00 1970 From: Roger Quadros Subject: Re: [PATCH 6/7] phy: omap-usb2: Add a new compatible string for USB2 PHY2 Date: Wed, 5 Aug 2015 11:23:31 +0300 Message-ID: <55C1C803.4030905@ti.com> References: <1438701646-7876-1-git-send-email-kishon@ti.com> <1438701646-7876-7-git-send-email-kishon@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1438701646-7876-7-git-send-email-kishon-l0cyMroinI0@public.gmane.org> Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Kishon Vijay Abraham I , tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org, t-kristo-l0cyMroinI0@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: balbi-l0cyMroinI0@public.gmane.org, nsekhar-l0cyMroinI0@public.gmane.org List-Id: linux-omap@vger.kernel.org On 04/08/15 18:20, Kishon Vijay Abraham I wrote: > The USB2 PHY2 has a different register map compared to USB2 PHY1 > to power on/off the PHY. In order to handle it, add a new > "compatible" string. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/phy/ti-phy.txt | 2 ++ > drivers/phy/phy-omap-usb2.c | 9 +++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt > index 49e5b0c..a061077 100644 > --- a/Documentation/devicetree/bindings/phy/ti-phy.txt > +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt > @@ -31,6 +31,8 @@ OMAP USB2 PHY > > Required properties: > - compatible: Should be "ti,omap-usb2" > + Should be "ti,dra7x-usb2-phy2" for the 2nd instance of USB2 PHY > + in DRA7x > - reg : Address and length of the register set for the device. > - #phy-cells: determine the number of cells that should be given in the > phandle while referencing this phy. > diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c > index b5c266a..2f7220f 100644 > --- a/drivers/phy/phy-omap-usb2.c > +++ b/drivers/phy/phy-omap-usb2.c > @@ -159,6 +159,11 @@ static const struct usb_phy_data dra7x_usb2_data = { > .flags = OMAP_USB2_CALIBRATE_FALSE_DISCONNECT, > }; > > +static const struct usb_phy_data dra7x_usb2_phy2_data = { > + .label = "dra7x_usb2_phy2", > + .flags = OMAP_USB2_CALIBRATE_FALSE_DISCONNECT, > +}; > + > static const struct usb_phy_data am437x_usb2_data = { > .label = "am437x_usb2", > .flags = 0, > @@ -178,6 +183,10 @@ static const struct of_device_id omap_usb2_id_table[] = { > .data = &dra7x_usb2_data, > }, > { > + .compatible = "ti,dra7x-usb2-phy2", > + .data = &dra7x_usb2_phy2_data, Why is this needed? You can reuse dra7x_usb2_data as is. > + }, > + { > .compatible = "ti,am437x-usb2", > .data = &am437x_usb2_data, > }, > cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751962AbbHEIXj (ORCPT ); Wed, 5 Aug 2015 04:23:39 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:57856 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751773AbbHEIXh (ORCPT ); Wed, 5 Aug 2015 04:23:37 -0400 Message-ID: <55C1C803.4030905@ti.com> Date: Wed, 5 Aug 2015 11:23:31 +0300 From: Roger Quadros User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.8.0 MIME-Version: 1.0 To: Kishon Vijay Abraham I , , , , , , CC: , Subject: Re: [PATCH 6/7] phy: omap-usb2: Add a new compatible string for USB2 PHY2 References: <1438701646-7876-1-git-send-email-kishon@ti.com> <1438701646-7876-7-git-send-email-kishon@ti.com> In-Reply-To: <1438701646-7876-7-git-send-email-kishon@ti.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/08/15 18:20, Kishon Vijay Abraham I wrote: > The USB2 PHY2 has a different register map compared to USB2 PHY1 > to power on/off the PHY. In order to handle it, add a new > "compatible" string. > > Signed-off-by: Kishon Vijay Abraham I > --- > Documentation/devicetree/bindings/phy/ti-phy.txt | 2 ++ > drivers/phy/phy-omap-usb2.c | 9 +++++++++ > 2 files changed, 11 insertions(+) > > diff --git a/Documentation/devicetree/bindings/phy/ti-phy.txt b/Documentation/devicetree/bindings/phy/ti-phy.txt > index 49e5b0c..a061077 100644 > --- a/Documentation/devicetree/bindings/phy/ti-phy.txt > +++ b/Documentation/devicetree/bindings/phy/ti-phy.txt > @@ -31,6 +31,8 @@ OMAP USB2 PHY > > Required properties: > - compatible: Should be "ti,omap-usb2" > + Should be "ti,dra7x-usb2-phy2" for the 2nd instance of USB2 PHY > + in DRA7x > - reg : Address and length of the register set for the device. > - #phy-cells: determine the number of cells that should be given in the > phandle while referencing this phy. > diff --git a/drivers/phy/phy-omap-usb2.c b/drivers/phy/phy-omap-usb2.c > index b5c266a..2f7220f 100644 > --- a/drivers/phy/phy-omap-usb2.c > +++ b/drivers/phy/phy-omap-usb2.c > @@ -159,6 +159,11 @@ static const struct usb_phy_data dra7x_usb2_data = { > .flags = OMAP_USB2_CALIBRATE_FALSE_DISCONNECT, > }; > > +static const struct usb_phy_data dra7x_usb2_phy2_data = { > + .label = "dra7x_usb2_phy2", > + .flags = OMAP_USB2_CALIBRATE_FALSE_DISCONNECT, > +}; > + > static const struct usb_phy_data am437x_usb2_data = { > .label = "am437x_usb2", > .flags = 0, > @@ -178,6 +183,10 @@ static const struct of_device_id omap_usb2_id_table[] = { > .data = &dra7x_usb2_data, > }, > { > + .compatible = "ti,dra7x-usb2-phy2", > + .data = &dra7x_usb2_phy2_data, Why is this needed? You can reuse dra7x_usb2_data as is. > + }, > + { > .compatible = "ti,am437x-usb2", > .data = &am437x_usb2_data, > }, > cheers, -roger