Re: [Qemu-devel] [PATCH V3 1/3] hw/vhost-user: remove unnecessary virtio control bits

[Marcel Apfelbaum <marcel.apfelbaum@gmail.com>]

On 07/31/2015 07:38 PM, Marcel Apfelbaum wrote:
> The backend is interested in negotiating only several
> virtio bits, remove the others.
>
> Signed-off-by: Marcel Apfelbaum <marcel@redhat.com>
> ---
>   hw/net/vhost_net.c | 22 ----------------------
>   1 file changed, 22 deletions(-)
>
> diff --git a/hw/net/vhost_net.c b/hw/net/vhost_net.c
> index c864237..90f97d2 100644
> --- a/hw/net/vhost_net.c
> +++ b/hw/net/vhost_net.c
> @@ -59,31 +59,9 @@ static const int kernel_feature_bits[] = {
>
>   /* Features supported by others. */
>   static const int user_feature_bits[] = {
> -    VIRTIO_F_NOTIFY_ON_EMPTY,
> -    VIRTIO_RING_F_INDIRECT_DESC,
> -    VIRTIO_RING_F_EVENT_IDX,
> -
>       VIRTIO_F_ANY_LAYOUT,
>       VIRTIO_F_VERSION_1,
> -    VIRTIO_NET_F_CSUM,
> -    VIRTIO_NET_F_GUEST_CSUM,
> -    VIRTIO_NET_F_GSO,
> -    VIRTIO_NET_F_GUEST_TSO4,
> -    VIRTIO_NET_F_GUEST_TSO6,
> -    VIRTIO_NET_F_GUEST_ECN,
> -    VIRTIO_NET_F_GUEST_UFO,
> -    VIRTIO_NET_F_HOST_TSO4,
> -    VIRTIO_NET_F_HOST_TSO6,
> -    VIRTIO_NET_F_HOST_ECN,
> -    VIRTIO_NET_F_HOST_UFO,
>       VIRTIO_NET_F_MRG_RXBUF,
> -    VIRTIO_NET_F_STATUS,
> -    VIRTIO_NET_F_CTRL_VQ,
> -    VIRTIO_NET_F_CTRL_RX,
> -    VIRTIO_NET_F_CTRL_VLAN,
> -    VIRTIO_NET_F_CTRL_RX_EXTRA,
> -    VIRTIO_NET_F_CTRL_MAC_ADDR,
> -    VIRTIO_NET_F_CTRL_GUEST_OFFLOADS,
>
>       VIRTIO_NET_F_MQ,
>
>

Hi,

Please do not take this patch, I think that some bits I deleted are still required by the backend.

The others are OK in my opinion (at least until we change the MQ handshake)
Thanks,
Marcel