From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51472) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMxHd-0007kT-QW for qemu-devel@nongnu.org; Wed, 05 Aug 2015 07:54:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZMxHZ-0000oE-4T for qemu-devel@nongnu.org; Wed, 05 Aug 2015 07:54:57 -0400 Received: from [59.151.112.132] (port=44858 helo=heian.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZMxHX-0000dk-0j for qemu-devel@nongnu.org; Wed, 05 Aug 2015 07:54:53 -0400 Message-ID: <55C1F971.8000207@cn.fujitsu.com> Date: Wed, 5 Aug 2015 19:54:25 +0800 From: Li Zhijian MIME-Version: 1.0 References: <1438159544-6224-1-git-send-email-zhang.zhanghailiang@huawei.com> <1438159544-6224-25-git-send-email-zhang.zhanghailiang@huawei.com> <20150805104238.GE2331@work-vm> In-Reply-To: <20150805104238.GE2331@work-vm> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH COLO-Frame v8 24/34] COLO NIC: Implement colo nic device interface configure() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Dr. David Alan Gilbert" , zhanghailiang Cc: quintela@redhat.com, Jason Wang , yunhong.jiang@intel.com, eddie.dong@intel.com, peter.huangpeng@huawei.com, qemu-devel@nongnu.org, arei.gonglei@huawei.com, Stefan Hajnoczi , amit.shah@redhat.com On 08/05/2015 06:42 PM, Dr. David Alan Gilbert wrote: > * zhanghailiang (zhang.zhanghailiang@huawei.com) wrote: >> Implement colo nic device interface configure() >> add a script to configure nic devices: >> ${QEMU_SCRIPT_DIR}/colo-proxy-script.sh >> >> Cc: Stefan Hajnoczi >> Cc: Jason Wang >> Signed-off-by: zhanghailiang >> Signed-off-by: Li Zhijian >> --- > I've not quite got this working right yet; after a failover, the secondary > hasn't connected the tap to the right bridge; I'm still trying to figure that out. at failover, colo will execute the qemu script(default: /etc/qemu-ifup) to bring up tap please check /etc/qemu-ifup Further more, qemu downscript *must* be specified and the downscript is needed to reset you networking configuration which is configured by qemu-ifup script following is a /etc/qemu-ifup and /etc/qemu-ifdown sample(both primary and secondary) root@master# cat /etc/qemu-ifup #!/bin/sh switch=br0 if [ -n "$1" ]; then ip link set $1 up brctl addif ${switch} $1 fi root@master# cat /etc/qemu-ifdown !/bin/sh switch=br0 if [ -n "$1" ]; then brctl delif ${switch} $1 fi >> + >> +secondary_uninstall() >> +{ >> + brctl delif $br $phy_if >> + brctl delif $br $virt_if >> + brctl addif $failover_br $virt_if >> + >> + /usr/local/sbin/iptables -t mangle -D PREROUTING -m physdev --physdev-in \ >> + $virt_if -j SECCOLO --index $index > I think this is new in this version; don't you still need the SECCOLO > mangle to fixup the sequence number of packets in existing connections so they > match the numbers that the PMY used? the kernel part code will help us to adjust sequence once we initialized the seq offest to kernel, so after failover, we don't need the SECCOLO mangle anymore Best regards. Li Zhijian > > Dave > >> + /usr/local/sbin/ip6tables -t mangle -D PREROUTING -m physdev --physdev-in \ >> + $virt_if -j SECCOLO --index $index >> +} >> + >> +if [ $# -ne 5 ]; then >> + script_usage >> + exit 1 >> +fi >> + >> +if [ "x$side" != "xprimary" ] && [ "x$side" != "xsecondary" ]; then >> + script_usage >> + exit 2 >> +fi >> + >> +if [ "x$action" != "xinstall" ] && [ "x$action" != "xuninstall" ]; then >> + script_usage >> + exit 3 >> +fi >> + >> +${side}_${action} >> -- >> 1.8.3.1 >> >> > -- > Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK > . >